Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: let jiti load @rspack/core with native require #4926

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Mar 31, 2025

Summary

Add @rspack/core to jiti's nativeModules options. This allows jiti load @rspack/core with native require() and avoids @rspack/core being loaded twice.

This PR should fixes the "The 'compilation' argument must be an instance of Compilation error" error after upgrade to v1.3.0.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Mar 31, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 8b48bdd
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/67ea25eb6d673700087efaad
😎 Deploy Preview https://deploy-preview-4926--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 54 (🔴 down 18 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit d4727c8 into main Mar 31, 2025
12 checks passed
@chenjiahan chenjiahan deleted the jiti_require_0331 branch March 31, 2025 05:27
@chenjiahan chenjiahan mentioned this pull request Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant