Skip to content

Conversation

@sofian-io
Copy link

Laravel projects use newer psr7 versions; this patch improves compatibility

Signed-off-by: Sofian Mourabit [email protected]

@svenzik
Copy link
Contributor

svenzik commented May 12, 2025

Hello,

could you clarify the issue with the current version notation in composer.json ("guzzlehttp/psr7": "^2.6.0") and explain how this patch improves compatibility?

The recommended operator for maximum interoperability when writing library code is a Caret Version Range.

Running composer update on main branch will include the same versions that you have in your PR:

Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 3 updates, 0 removals
  - Upgrading guzzlehttp/psr7 (2.7.0 => 2.7.1)
  - Upgrading myclabs/deep-copy (1.13.0 => 1.13.1)
  - Upgrading phpunit/phpunit (10.5.45 => 10.5.46)
Writing lock file

Would you also mind providing the specific steps to reproduce the issue you're encountering, when using notation "^2.6.0"?

@mrts mrts added the invalid This doesn't seem right label May 20, 2025
@mrts
Copy link
Member

mrts commented May 20, 2025

Closing as invalid. @sofian-io, please feel free to explain why this is needed and we will reopen.

We tested with composer require web-eid/web-eid-authtoken-validation-php:dev-main in a newly created Laravel project and everything was working well.

@mrts mrts closed this May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants