Repository navigation
fix(config): raise when an update tries to change the vector index type - #2194
Open
jackiectl2 wants to merge 1 commit into
Open
jackiectl2 wants to merge 1 commit into
jackiectl2 wants to merge 1 commit into
Conversation
The vector index type is immutable server-side. Updating a single-vector collection with a different index type was silently ignored, and doing so for a named vector made the server fail with an internal error. Raise a WeaviateInvalidInputError client-side instead. Fixes weaviate#1277 Signed-off-by: Tianlang (Jackie) Chen <305351710+jackiectl2@users.noreply.github.com>
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
Author
|
I agree with the CLA. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1277
The vector index type of a collection / named vector is immutable server-side, but
collection.config.update()didn't check it:config.update(vectorizer_config=Reconfigure.VectorIndex.dynamic())on aflatcollection returned without error and the index stayedflat—vectorIndexTypeis never sent, the new fields are just merged into the old config.vectorIndexTypetogether with the old index config; against Weaviate 1.39.7 changingflat->hnsw/dynamicreturns HTTP 500 (server log:interface conversion: interface {} is flat.UserConfig, not hnsw.UserConfig).This adds a client-side check in
_CollectionConfigUpdate.merge_with_existing(all four vector index update paths) that raisesWeaviateInvalidInputErrorwhen the requested index type differs from the existing one, similar to the existing quantizer-switch check. Updates that keep the same index type are unchanged. (An earlier attempt, #2080, was closed by its author without review; this takes the same approach.)Testing
test/collection/test_config_update.py(single vector viavector_index_config/vectorizer_config, named vector viaNamedVectors.update/Vectors.update, plus same-type updates still merging). The raise tests fail without the change.pytest test(531 passed),pytest mock_tests(65 passed),ruff format,ruff check,flake8clean.