This repository was archived by the owner on Feb 17, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 51
Acs 2 #105
Open
olliethomas
wants to merge
6
commits into
master
Choose a base branch
from
acs-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Acs 2 #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this definitely will be full of mistakes, but pushing as requested |
tmke8
suggested changes
May 19, 2020
numpy-stubs/__init__.pyi
Outdated
@@ -280,6 +280,7 @@ class ndarray(Generic[_DType]): | |||
self, | |||
key: Union[ | |||
None, | |||
range, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't seem to be used anywhere
Suggested change
range, |
numpy-stubs/random.pyi
Outdated
@@ -43,6 +54,9 @@ def exponential(scale: _FloatObj, size: Sequence[_IntObj]) -> ndarray[float64]: | |||
def exponential(scale: Sequence[_FloatObj], size: Sequence[_IntObj]) -> ndarray[float64]: ... | |||
def geometric(p: float, size: _IntObj) -> ndarray[float64]: ... | |||
def get_state() -> Tuple[str, ndarray[_Int], _IntObj, _IntObj, _FloatObj]: ... | |||
def multinomial( | |||
n: int, pvals: _ArrayLike[float] = ..., size: Union[int, Tuple[int, ...]] = ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
n: int, pvals: _ArrayLike[float] = ..., size: Union[int, Tuple[int, ...]] = ... | |
n: int, pvals: _ArrayLike[_Float] = ..., size: Union[int, Tuple[int, ...]] = ... |
this should at least get rid of the error. not sure if it's correct though
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.