Skip to content

handle different length on mixpath #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

handle different length on mixpath #482

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f733735
handle different length on mixpath
Mar 18, 2022
1c0a38c
adjust comment
Mar 18, 2022
b734a1f
better animation handling for different path adjustments
Mar 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions src/Paths.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,31 @@ export const mixPath = (
extrapolate = Animated.Extrapolate.CLAMP
) => {
"worklet";

// handle issues on different path length
// https://github.com/wcandillon/react-native-redash/issues/466

if (p2.curves.length !== p1.curves.length) {
const maxY = Math.max(...p2.curves.map((c) => c.c1.y));
const p1a = {
...p2,
curves: p2.curves.map((_curve) => {
const c = JSON.parse(JSON.stringify(_curve));

c.c1.x = 0;
c.c2.x = 0;
c.to.x = 0;

c.c1.y = maxY;
c.c2.y = maxY;
c.to.y = maxY;

return c;
}),
};
return interpolatePath(value, [0, 1], [p1a, p2]);
}

return interpolatePath(value, [0, 1], [p1, p2], extrapolate);
};

Expand Down