Skip to content

Making sure withOffset works in tandem #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Making sure withOffset works in tandem #267

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f4c991b
Making sure withOffset works in tandem
timbrandin May 7, 2020
a463e22
This worked better actually, because it only updates when state changes.
timbrandin May 7, 2020
13d92b7
fix styling
timbrandin May 8, 2020
8b6edc9
Not sure what the difference is between Animated.Node and Value
timbrandin May 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions packages/core/src/Gesture.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,15 +67,19 @@ export const withScaleOffset = (
);

export const withOffset = (
value: Animated.Node<number>,
value: Animated.Value<number>,
state: Animated.Node<State>,
offset: Animated.Value<number> = new Value(0)
) =>
cond(
eq(state, State.END),
[set(offset, add(offset, value)), offset],
add(offset, value)
);
block([
onChange(state, [
cond(eq(state, State.END), [
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

value shouldn't be written here. Should it be a separate function?

set(offset, add(offset, value)),
set(value, 0),
]),
]),
add(offset, value),
]);

interface PrivateSpringConfig extends Animated.SpringConfig {
toValue: Animated.Value<number>;
Expand Down