Update d.json added plugin DuplExpellio

[JohhannasReyn]

Added plugin DuplExpellio after implementing the suggested revisions.

• I'm the package's author and/or maintainer.
• I have have read the docs.
• I have tagged a release with a semver version number.
• My package repo has a description and a README describing what it's for and how to use it.
• My package doesn't add context menu entries. *
• My package doesn't add key bindings. **
• Any commands are available via the command palette.
• Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
• If my package is a syntax it doesn't also add a color scheme. ***
• If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
• I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is ...

There are no packages like it in Package Control. It's like a snowflake, totally unique! ...just like every other snowflake 😕

[packagecontrol-bot]

Automated testing result: SUCCESS

Repo link: DuplExpellio

Packages added:
  - DuplExpellio

Processing package "DuplExpellio"
  - All checks passed

[braver]

I don't think your approach to Context.sublime-menu is going to work. Remember that users can't edit your files directly once they're shipped as package. They would haver to copy some lines over to their personal copy of a file (like they do with settings and keybindings files). For menus the better approach is usually to have a setting that you check in is_enabled() to allow users to turn context menu commands off. This usually also involved having a new command implementation specifically for the context menu (which can then of course call the existing command).

[JohhannasReyn]

That makes a lot of sense, sorry for the confusion. I will correct this as soon as I can, once corrected will I need to submit another pull request, or just let you know here? And thank you for taking the time to explain this to me, your feedback is much appreciated.

…

On Sun, 12 Jan 2025 at 11:55, Koen Lageveen ***@***.***> wrote: I don't think your approach to Context.sublime-menu <https://github.com/JohhannasReyn/DuplExpellio/blob/main/Context.sublime-menu> is going to work. Remember that users can't edit your files directly once they're shipped as package. They would haver to copy some lines over to their personal copy of a file (like they do with settings and keybindings files). For menus the better approach is usually to have a setting that you check in is_enabled() to allow users to turn context menu commands off. This usually also involved having a new command implementation specifically for the context menu (which can then of course call the existing command). — Reply to this email directly, view it on GitHub <#9035 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A6P4CPSAL5WVR66L5FRW7UT2KLCCBAVCNFSM6AAAAABU7NZ4MKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBVHA4TKNRUGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[JohhannasReyn]

Hi again, I just updated the plugin to align with your suggestions, I did a complete overhaul on it, took a bit of work but it's done and is working beautifully! Do I need to submit a new pull request for this update? On Mon, 13 Jan 2025 at 02:39, Johhannas Reyn ***@***.***> wrote:

…

That makes a lot of sense, sorry for the confusion. I will correct this as soon as I can, once corrected will I need to submit another pull request, or just let you know here? And thank you for taking the time to explain this to me, your feedback is much appreciated. On Sun, 12 Jan 2025 at 11:55, Koen Lageveen ***@***.***> wrote: > I don't think your approach to Context.sublime-menu > <https://github.com/JohhannasReyn/DuplExpellio/blob/main/Context.sublime-menu> > is going to work. Remember that users can't edit your files directly once > they're shipped as package. They would haver to copy some lines over to > their personal copy of a file (like they do with settings and keybindings > files). For menus the better approach is usually to have a setting that you > check in is_enabled() to allow users to turn context menu commands off. > This usually also involved having a new command implementation specifically > for the context menu (which can then of course call the existing command). > > — > Reply to this email directly, view it on GitHub > <#9035 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/A6P4CPSAL5WVR66L5FRW7UT2KLCCBAVCNFSM6AAAAABU7NZ4MKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBVHA4TKNRUGE> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> >

[braver]

Do I need to submit a new pull request for this update

No, that's only required when you change your entry in this repo.

I just updated the plugin to align with your suggestions, I did a
complete overhaul

Did you push that work to your repo?

[JohhannasReyn]

Sorry for the confusion, I'm still getting the hang of this, I cancelled my previous pull request for Mardown2Dir and created a new one following the last edits I made to my plugin. Just for clarification if say down the road, I discover something I wish to change, want to implement another feature, or add an option to the settings, I would need to create another pull request after editing the code in the plugin's repository, correct? But then, if my plugin is already listed in the appropriate repo (in this instance `m.json`), what changes would be made to the new package control channel branch for the updated plugin to be re-checked and approved for inclusion, being that it's entry in the corresponding repository will already exist?

…

On Sun, 26 Jan 2025 at 08:45, Koen Lageveen ***@***.***> wrote: Do I need to submit a new pull request for this update No, that's only required when you change your entry in this repo. I just updated the plugin to align with your suggestions, I did a complete overhaul Did you push that work to your repo? — Reply to this email directly, view it on GitHub <#9035 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A6P4CPTZXZAEK3NLXNJPUQT2MUGLTAVCNFSM6AAAAABU7NZ4MKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJUGUYDANBWGM> . You are receiving this because you authored the thread.Message ID: ***@***.***>