Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add co-author to existing package (Update e.json) #9029

Closed
wants to merge 1 commit into from

Conversation

axemonk
Copy link
Contributor

@axemonk axemonk commented Jan 2, 2025

Added co-author @michaelblyons

  • I'm the package's author and/or maintainer.
  • I have have read [the docs][1].
  • I have tagged a release with a [semver][2] version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").

My package is an existing package adding support for syntax highlighting for Excel formulas (with aspirational support for GSheets and others).

There are no packages like it in Package Control.

Added a co-author
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Packages modified:
  - Excel formula

@michaelblyons
Copy link
Contributor

michaelblyons commented Jan 13, 2025

I endorse this. I'm not sure if that was clear.

@axemonk You may want to edit the PR title to say that the change just adds a co-author to Excel formula.

@axemonk axemonk changed the title Update e.json Add co-author to existing package (Update e.json) Jan 14, 2025
@axemonk
Copy link
Contributor Author

axemonk commented Jan 14, 2025

thanks for the heads up @michaelblyons. Done.

@axemonk
Copy link
Contributor Author

axemonk commented Jan 20, 2025

Update: eventually we will want to rename this package to be "Spreadsheet formula" instead of "Excel formula" (it now supports spreadsheet applications other than just Excel), with "Excel formula" being added to the "previous_names" key instead. Since that will change the proper position of this package in the Package Control repository according to alphabetization, I'm not sure what the best way to go about that is (should I close this pull request before reopening it with both the original change and the move/rename committed instead?). Please let me know if you have any specific guidance. Thanks.

@braver
Copy link
Collaborator

braver commented Jan 26, 2025

Since that will change the proper position of this package in the Package Control repository according to alphabetization

A package's name is its unique identifier. If you rename a package, move the entry to the new alphabetical position (ie. delete the old one, create a new one). The "previous_names" key will ensure package control knows to treat it as the same package as before but under a different name.

should I close this pull request before reopening it with both the original change and the move/rename committed instead?

Yes please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants