Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TextTree syntax highlighter #9028

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

mdoering
Copy link

@mdoering mdoering commented Jan 2, 2025

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is ...

There are no packages like it in Package Control.

My package is similar to ... However it should still be added because ...

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: TextTree
Results help

Packages added:
  - TextTree

Processing package "TextTree"
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: TextTree.sublime-syntax

@braver
Copy link
Collaborator

braver commented Jan 26, 2025

Your syntax uses uncommon scope names (please refer to the guide). I'm sure that with some effort you can find scope names that will allow users to use their preferred color scheme instead of the one your package ships with. Users care very deeply about color schemes, and you can't expect them to use yours just because of your syntax, even via a language specific setting. Users might prefer a light color scheme, or prefer a certain level of contrast. Not just aesthetically, but also for accessibility reasons.

@mdoering
Copy link
Author

I have released a new version 1.0.2 that tries to use standard scopes as much as possible. Hope it makes sense as this syntax is not a language, but rather a data format. In any case you can use it now with existing color schemes nicely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants