Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blitz Search #8937

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Blitz Search #8937

merged 2 commits into from
Jun 19, 2024

Conversation

Natestah
Copy link
Contributor

  • [ ✔️] I'm the package's author and/or maintainer.
  • [✔️ ] I have have read [the docs][1].
  • [ ✔️] I have tagged a release with a [semver][2] version number.
  • [✔️ ] My package repo has a description and a README describing what it's for and how to use it.
  • [✔️ ] My package doesn't add context menu entries. *
  • [✔️ ] My package doesn't add key bindings. **
  • [✔️ ] Any commands are available via the command palette.
  • [ ✔️] Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.

My package is ...

There are no packages like it in Package Control. Blitz Search Provides a simple interface to control what is being search in the external Blitz Search Tool that I'm developing at natestah.com.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: BlitzSearch
Results help

Packages added:
  - BlitzSearch

Processing package "BlitzSearch"
  - WARNING: The package does not contain a top-level LICENSE file. A license helps users to contribute to the package.

@braver
Copy link
Collaborator

braver commented Jun 19, 2024

Thanks for your addition here. I'm not going to necessarily test your package, but from a quick read.. are you sure this is going to work on someone else's machine?

ipcPath = os.path.join(appdata, 'NathanSilvers','POORMANS_IPC')
ipcFile = os.path.join(ipcPath,'SET_SEARCH.txt' )

@Natestah
Copy link
Contributor Author

Good catch.. I've updated and added a licence.md to the root of that repo.

@kaste
Copy link
Contributor

kaste commented Jun 19, 2024

Please lift the plugin to run on the 3.8 host. For that, create a file .python-version with its only contents 3.8\n in the root of your package.

The video on your website shows a way fancier live/on-the-fly search thing using a typical text/input panel/box. Could you expand this demo plugin to that? Would that be the goal?

@braver braver merged commit 4daa961 into wbond:master Jun 19, 2024
2 checks passed
@Natestah
Copy link
Contributor Author

Please lift the plugin to run on the 3.8 host. For that, create a file .python-version with its only contents 3.8\n in the root of your package.

The video on your website shows a way fancier live/on-the-fly search thing using a typical text/input panel/box. Could you expand this demo plugin to that? Would that be the goal?

This plugin requires a download from the website of the external tool. The goal with the plugin is that I'll never really have to change anything plugin-wise. It's a very thin layer so that I can have Blitz Search Running in more than one text editor / IDE.

You can run the "Blitz Search This" command which will highlight the text in the box, from there you can type over that with whatever you want and search for anything.

@Natestah
Copy link
Contributor Author

There's a number of things to do with the tool itself. Perhaps the worst part of being independent is that people are going to have to click through scary "Windows Defender messages" to get it installed. Which is unfortunate for me, I've only had a few friends testing it so far. There's a discord channel if you're feeling bold and brave enough to click through those. Updated that python-version file for you

@kaste
Copy link
Contributor

kaste commented Jun 20, 2024

Yeah, I thought it would be real IPC in the long run; you send the contents of an input field to a Blitz-server, and display the response in an editor view. A real-time, as-you-type search is missing in Sublime.

@Natestah
Copy link
Contributor Author

The real IPC thing was a thought early on but I realized I would have to do UI in Many Unfamiliar languages to get a Uniform support, I decided to stick with my strength C# WPF (now Avalonia) where I could do awesome things and then implement this super simple plugin for as many Editors as possible, I plan to do this same thing for a chrome/any browser extension where we can find-locally from within web-browser ( Github, Perforce Swarm Reviews, etc ).

Not to say that it won't ever happen, I have actually framed it up to be "Client/Server" internally to where the Query is a MessagePack object that is Serialized/Deserialized for every requests even though it's in-process, and even tracking the process/identification of each request. The predecessor to this had a Real IPC and Multiple instances of the In-house IDE could access the search server so I kind of have an idea of what that looks like.

It's good that you mentioned it.. Maybe I'll build up some sort of API in the future and delegate that to who ever wants to have a true built in Search in their editor of choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants