Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby Gems viewer package #8929

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Add Ruby Gems viewer package #8929

merged 3 commits into from
Jun 20, 2024

Conversation

ZainIftikhar7vals
Copy link
Contributor

@ZainIftikhar7vals ZainIftikhar7vals commented Jun 3, 2024

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is Ruby Gem viewer.

There are no packages like it in Package Control.

@ZainIftikhar7vals ZainIftikhar7vals changed the title Update g.json Add Ruby Gems viewer package Jun 3, 2024
@kaste
Copy link
Contributor

kaste commented Jun 17, 2024

This looks good to me but I do wonder

      gem_home = os.popen("echo $GEM_HOME").read().split("\n")[0]
      gems_directories = [
        os.path.expanduser("%s/gems/" % gem_home),
        os.path.expanduser("%s/bundler/gems/" % gem_home)
      ]

Isn't that readable just from within Sublime Text using os.environ["GEM_HOME"]. Would be nice to make it available for Windows too. Is that impossible to achieve?

The latest tag right now is "0.2.0-alpha". Not sure if a suffix (-alpha) counts as release version. braver will know that, or change it to just 0.3.0.

@kaste
Copy link
Contributor

kaste commented Jun 18, 2024

  • Please lift the plugin to run on the 3.8 host. For that, create a file .python-version with its only contents 3.8\n in the root of your package.

@ZainIftikhar7vals
Copy link
Contributor Author

  • Please lift the plugin to run on the 3.8 host. For that, create a file .python-version with its only contents 3.8\n in the root of your package.

Can you please explain it a little bit more, as I am new to Sublime package development?

@ZainIftikhar7vals
Copy link
Contributor Author

Would be nice to make it available for Windows too. Is that impossible to achieve?

It's definitely possible, but since I don't have access to a Windows machine right now, I can't test it. However, I plan to do so in the future.

@kaste
Copy link
Contributor

kaste commented Jun 19, 2024

Yeah, to "lift" the package (or better worded: choose the environment) create a file just like https://github.com/kaste/InlineOutline/blob/master/.python-version.

@ZainIftikhar7vals
Copy link
Contributor Author

ZainIftikhar7vals commented Jun 20, 2024

@kaste All comments resolved.

@kaste
Copy link
Contributor

kaste commented Jun 20, 2024

We need @braver for the merge.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: GotoRubyGem

Packages added:
  - GotoRubyGem

Processing package "GotoRubyGem"
  - All checks passed

Copy link

@koen-at-peppered koen-at-peppered left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some final tweaks to the entry here, looks good otherwise 👍

@ZainIftikhar7vals
Copy link
Contributor Author

@koen-at-peppered changes have been incorporated, please review.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: GotoRubyGem

Packages added:
  - GotoRubyGem

Processing package "GotoRubyGem"
  - All checks passed

@braver braver merged commit 653b97f into wbond:master Jun 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants