Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sass: v3 tags, prep for 4169+ #8891

Merged
merged 3 commits into from
Mar 16, 2024
Merged

Sass: v3 tags, prep for 4169+ #8891

merged 3 commits into from
Mar 16, 2024

Conversation

braver
Copy link
Collaborator

@braver braver commented Mar 16, 2024

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Packages modified:
  - Sass

@deathaxe
Copy link
Contributor

How about using least required ST build number as prefix?

LSP started to use it and it has proven useful as it clearly indicates which version is required.

@braver
Copy link
Collaborator Author

braver commented Mar 16, 2024

Yeah that’s smart, we’ll probably need to freeze and branch off some more for future versions

@deathaxe
Copy link
Contributor

Appears bundling CSS is an easy task.

Hence I suggest creating a 4107- prefix which points to st4107 branch, which includes bundled CSS from ST4169 and a 4169- prefix, which points to current master (without the CSS file).

The v2- and v3- prefixes are obsolete then and all stable ST4 releases are served with latest fixes.

@deathaxe
Copy link
Contributor

deathaxe commented Mar 16, 2024

With the tags and branch created in Sass Repo, we could go with this.

		{
			"name": "Sass",
			"details": "https://github.com/SublimeText/Sass",
			"labels": ["language syntax", "scss", "sass", "completions", "snippets"],
			"releases": [
				{
					"sublime_text": "<4107",
					"tags": "st3-"
				},
				{
					"sublime_text": "4107 - 4133",
					"tags": "4107-"
				},
				{
					"sublime_text": "4134 - 4168",
					"tags": "4134-"
				},
				{
					"sublime_text": ">=4169",
					"tags": "4169-"
				}
			]
		},

EDIT: Due to Markdown change, we need to branch off at 4134, once.

With this structure, we have 3 parallel branches for each supported ST build.

The older backport versions are branched off from master. Thus any backward compatible fix, can merged from master into those backport branches until we decide to drop one of the older releases.

@braver
Copy link
Collaborator Author

braver commented Mar 16, 2024

4169 is the latest stable build. I've always gotten very little feedback from users on this package, so I personally feel very little need to go to all this effort to serve users who have not recently upgraded to the latest stable build of ST4. Never hurts though of course 😄

That said, looks like you put in the work already, so let's go with that 👍🏻

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Packages modified:
  - Sass

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Packages modified:
  - Sass

@braver
Copy link
Collaborator Author

braver commented Mar 16, 2024

@deathaxe looks like we're all set. Let me know if you're also ready to hit merge here.

@deathaxe
Copy link
Contributor

deathaxe commented Mar 16, 2024

Let's go.

I don't have created an update message so far, though. The update would come silently.

@deathaxe
Copy link
Contributor

We propably should merge ASAP. I wasn't aware of Package Control already picking up the 4.0.0 tag.

@deathaxe
Copy link
Contributor

It might break SCSS for older ST4 releases.

@braver
Copy link
Collaborator Author

braver commented Mar 16, 2024

Oh, right, of course it would do that. I added a message, moved some tags around. Should be all good now 🤞🏻

@braver braver merged commit 554f019 into wbond:master Mar 16, 2024
2 checks passed
@braver braver deleted the braver-sass branch March 16, 2024 20:52
@deathaxe
Copy link
Contributor

Backported it to st4107 and st4134 branches and updated their tags.

4.0.0 is currently set onto st4134 branch so everyone upgrading until next crawler cycle will get it with bundled CSS to avoid failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants