Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PIO Syntax #8880

Merged
merged 2 commits into from
Mar 10, 2024
Merged

Add PIO Syntax #8880

merged 2 commits into from
Mar 10, 2024

Conversation

patopesto
Copy link
Contributor

@patopesto patopesto commented Feb 25, 2024

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is a syntax for the PIO assembly language found on RPI Pico controllers.

There are no packages like it in Package Control.

@patopesto
Copy link
Contributor Author

Not sure I fully understand why the trigger-review CI job failed. Any help would be appreciated.

@braver
Copy link
Collaborator

braver commented Mar 9, 2024

There seems to be an issue with tests and GitLab hosted packages. Your work looks good though, so I think we can just ignore that.

One thing though, your syntax requires a reasonably recent version of ST, so please set the version requirements to "sublime_text": ">=4107".

@braver braver merged commit 06e5041 into wbond:master Mar 10, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants