Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take-over Compare Side-By-Side #8877

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Take-over Compare Side-By-Side #8877

merged 2 commits into from
Feb 28, 2024

Conversation

kaste
Copy link
Contributor

@kaste kaste commented Feb 22, 2024

  • I'm the package's author and/or maintainer.
  • I have have read [the docs][1]. Yeah, at some point but it's been a while.
  • I have tagged a release with a [semver][2] version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use [.gitattributes][3] to exclude files from the package: images, test files, sublime-project/workspace.

My package is https://github.com/kaste/Compare-Side-By-Side forked from https://bitbucket.org/dougty/sublime-compare-side-by-side/

The original repo has not been updated to work with ST4. The PRs were ignored. There is no interaction at all. The hosted screenshots (now removed from the README) have been deleted.

  • This is a minimal take-over, just making it work. The repo history is intact.
  • (Change:) Doesn't add global key bindings, ie. it uses contextualized bindings 🚀
  • (Change:) Uses the standard edit_settings in the main menu for editing the settings in split view fashion
  • (Change:) Runs on py3.8

Actually I'm running this (my) version for years now and it should be on PC. I just hoped initially someone else would make it. Now I do.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Packages modified:
  - Compare Side-By-Side

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Packages modified:
  - Compare Side-By-Side

@braver
Copy link
Collaborator

braver commented Feb 27, 2024

The proper process here would be to open an issue on their repo (if you haven’t already) and wait for two weeks. If there is no response, we can merge this PR.

@kaste
Copy link
Contributor Author

kaste commented Feb 27, 2024

Gone. Issues are closed. PR without comments since ST4 rolled out. Also the only project by dougty (Doug Tyrrell) on bitbucket, the email is not used on GitHub. The url https://dougty.com/ is dead. 🤷‍♀️ 😢 What is important too is that I don't squashed the history. All commits are of course intact. It is really clear that I made nothing here.

@FichteFoll FichteFoll added the takeover Package maintainership is changing label Feb 27, 2024
@braver
Copy link
Collaborator

braver commented Feb 28, 2024

Well in that case, 🚀

@braver braver merged commit 2f27742 into wbond:master Feb 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
takeover Package maintainership is changing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants