-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Elevator #8875
Add Elevator #8875
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: ERROR
Repo link: Elevator
Results help
Packages added:
- Elevator
Processing package "Elevator"
- ERROR: Invalid key '<character>'
- File: Default.sublime-keymap
- Binding: {"args": {"forward": false}, "command": "elevator_move", "keys": ["alt+up", "<character>"]}
- ERROR: Invalid key '<character>'
- File: Default.sublime-keymap
- Binding: {"args": {"forward": true}, "command": "elevator_move", "keys": ["alt+down", "<character>"]}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: SUCCESS
Repo link: Elevator
Packages added:
- Elevator
Processing package "Elevator"
- All checks passed
Looks like you're basically providing what LineJumper already does. That's a pretty stale package though. Please find out if you can contribute to that package instead of adding a new package. Maybe you can even take over that repo. Otherwise, if that does not work out, we can consider removing that existing package with yours, and bring the updated and improved functionality to more users. |
Please let us know if things worked out with LineJumper. |
Will do. I contacted the author 👍 |
Looks like the answer to your question is "no" 😄. Feel free to proceed with a replacement of the existing entry with yours. |
Oh, this has been out of my radar. Yeah, tried reaching out but he did not reply. What should I do to proceed? |
The cleanest thing to do is remove the existing entry for LineJumper, and add "LineJumper" to the previous_names of your package (example: https://github.com/wbond/package_control_channel/pull/8875/files#diff-2b7dc45bc94d46ab4847d3281d04dac17d5f228e762a8491333857d6ca7cc6d2R455). Also ensure your package has a version higher than the last one for LineJumper (1.0.0). This effectively replaces that with yours and will upgrade existing users to the latest version of your package. Bonus points for adding an upgrade message (docs) telling those users what happened. |
Ok. Got it. I will close this for now. I will add the highlighting feature from linejumper and reopen this PR. |
My package is Elevator
There are no packages like it in Package Control.
My package is similar to ... However it should still be added because ...