Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JunLang #8855

Merged
merged 5 commits into from
Dec 18, 2023
Merged

Add JunLang #8855

merged 5 commits into from
Dec 18, 2023

Conversation

lemonorangeapple
Copy link
Contributor

@lemonorangeapple lemonorangeapple commented Dec 14, 2023

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is JunLang

There are no packages like it in Package Control.

@lemonorangeapple
Copy link
Contributor Author

@packagecontrol-bot .

channel.json Outdated Show resolved Hide resolved
repository/j.json Outdated Show resolved Hide resolved
@braver
Copy link
Collaborator

braver commented Dec 16, 2023

Please have a look the scope naming guide and ensure your scopes all end with .junlang.

@lemonorangeapple
Copy link
Contributor Author

@braver I changed them. Can it work now?

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: JunLang
Results help

Packages added:
  - JunLang

Processing package "JunLang"
  - WARNING: Creating a readme for your package will help users understand what it does and how to use it
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: JunLang.sublime-syntax

@braver
Copy link
Collaborator

braver commented Dec 18, 2023

That's better :) Please do add a README, otherwise people won't really understand what your package is about. For instance, link to information about the language your package supports.

Also please don't forget to tag a new release with your improvements, package control only sees your tags: other changes are just sitting there in your repo and won't make it to end users.

Let's not let that stop us from shipping this. Just do those things in your own time.

@braver braver merged commit 3ed3992 into wbond:master Dec 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants