Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ScrollToCursor package #8852

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Add ScrollToCursor package #8852

merged 1 commit into from
Dec 18, 2023

Conversation

SelimJB
Copy link
Contributor

@SelimJB SelimJB commented Nov 26, 2023

  • I'm the package's author and/or maintainer.
  • I have have read [the docs][1].
  • I have tagged a release with a [semver][2] version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.

My package is unique, and there are no packages like it in Package Control.

@SelimJB SelimJB changed the title Add ScrollToCursor package to Package Control Channel Add ScrollToCursor package Nov 26, 2023
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: ERROR

Repo link: ScrollToCursor
Results help

Packages added:
  - ScrollToCursor

Processing package "ScrollToCursor"
  - ERROR: The package contains 1 Python file(s), but none of them are in the package root and no build system is specified
  - WARNING: The package does not contain a top-level LICENSE file. A license helps users to contribute to the package.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: ScrollToCursor

Packages added:
  - ScrollToCursor

Processing package "ScrollToCursor"
  - All checks passed

@braver
Copy link
Collaborator

braver commented Dec 16, 2023

Thanks. Some feedback:

  • Please remove the sublime-package.json file, it's not needed (your package metadata is in this PR after all)
  • Please create a main menu entry for your settings
  • Ensure the settings open in split-view from both the menu and command palette (look at the various examples out there)
  • Please remove the archives, just tag releases and let git and package control handle it

@SelimJB
Copy link
Contributor Author

SelimJB commented Dec 17, 2023

Done :)

@braver
Copy link
Collaborator

braver commented Dec 18, 2023

Looks good, thanks! Don't forget to tag a new release with those improvements though.

@braver braver merged commit 14e17d3 into wbond:master Dec 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants