Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Quote With Marker Package. #8846

Merged
merged 5 commits into from
Nov 22, 2023
Merged

Conversation

dennykorsukewitz
Copy link
Contributor

@dennykorsukewitz dennykorsukewitz commented Nov 7, 2023

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package does not add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is Quote With Marker

quotewithmarker

There are no packages like it in Package Control.

@dennykorsukewitz dennykorsukewitz changed the title Added Quote With Marker Package Added Quote With Marker Package. Nov 7, 2023
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: ERROR

Repo link: Quote With Marker
Results help

Packages added:
  - Quote With Marker

Processing package "Quote With Marker"
  - ERROR: Branch-based releases are not supported for new packages; please use "tags": true
  - WARNING: The package does not contain a top-level LICENSE file. A license helps users to contribute to the package.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: ERROR

Repo link: Quote With Marker
Results help

Packages added:
  - Quote With Marker

Processing package "Quote With Marker"
  - ERROR: Branch-based releases are not supported for new packages; please use "tags": true

@dennykorsukewitz dennykorsukewitz marked this pull request as ready for review November 8, 2023 08:24
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Quote With Marker

Packages added:
  - Quote With Marker

Processing package "Quote With Marker"
  - All checks passed

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Quote With Marker

Packages added:
  - Quote With Marker

Processing package "Quote With Marker"
  - All checks passed

repository/q.json Outdated Show resolved Hide resolved
@braver
Copy link
Collaborator

braver commented Nov 19, 2023

QuoteWithMarker is a Sublime Text 2/3 package

🤔 That's a bit of a weird audience since ST4 has been out for years already.

My package does add key bindings. ** But so hard to trigger.

Haha, yeah, that takes some gymnastics. Good reason to not ship with any at all and let users set something easier to do and to remember 😉

There are no packages like it in Package Control

Indeed, I don't think I ever saw something like it. Nice 👍🏻

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Quote With Marker

Packages added:
  - Quote With Marker

Processing package "Quote With Marker"
  - All checks passed

@dennykorsukewitz
Copy link
Contributor Author

QuoteWithMarker is a Sublime Text 2/3 package

🤔 That's a bit of a weird audience since ST4 has been out for years already.

Yes, I built the package for myself for version 2 and 3 back then.
But it currently also works for version 4 and I have changed the description. 👍🏼
Fixed: dennykorsukewitz/Sublime-QuoteWithMarker@1dcb78f

My package does add key bindings. ** But so hard to trigger.

Haha, yeah, that takes some gymnastics. Good reason to not ship with any at all and let users set something easier to do and to remember 😉

You're probably right.
Fixed: dennykorsukewitz/Sublime-QuoteWithMarker@69cb6b5

There are no packages like it in Package Control

Indeed, I don't think I ever saw something like it. Nice 👍🏻

Thanks, do you like it?
If you have to patch a file and compare it with the original from time to time, this is very helpful.

@braver braver merged commit 50d5577 into wbond:master Nov 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants