Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B2 Jam Syntax Highlighting #8839

Merged
merged 1 commit into from
Nov 19, 2023
Merged

B2 Jam Syntax Highlighting #8839

merged 1 commit into from
Nov 19, 2023

Conversation

mccann
Copy link
Contributor

@mccann mccann commented Oct 24, 2023

Add B2Jam project

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is ...

There are no packages like it in Package Control.

My package is similar to ... However it should still be added because ...

Add B2Jam project
@mccann
Copy link
Contributor Author

mccann commented Oct 24, 2023

the .gitattributes question is unclear, should I remove the images that are included which are used by the README.md ?

@rwols
Copy link
Contributor

rwols commented Oct 24, 2023

You can omit anything that doesn’t contribute to the functioning of the sublime plugin. That probably includes images referenced in the readme.

@mccann
Copy link
Contributor Author

mccann commented Oct 24, 2023

You can omit anything that doesn’t contribute to the functioning of the sublime plugin. That probably includes images referenced in the readme.

Great, done. Added .gitattributes with export-ignore for 'readme-imgs/'

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: B2Jam
Results help

Packages added:
  - B2Jam

Processing package "B2Jam"
  - WARNING: The binding ['backspace'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['['] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['['] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding [']'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['backspace'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['enter'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['('] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['('] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['backspace'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding [')'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['enter'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['{'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['{'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['backspace'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['}'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['enter'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap

@braver
Copy link
Collaborator

braver commented Nov 19, 2023

Very nice job sir 👍🏻

@braver braver merged commit bd9909c into wbond:master Nov 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants