Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add LogbackJsonLogViewer plugin #8802

Merged
merged 8 commits into from
Jan 5, 2024
Merged

add LogbackJsonLogViewer plugin #8802

merged 8 commits into from
Jan 5, 2024

Conversation

neno--
Copy link
Contributor

@neno-- neno-- commented Aug 1, 2023 •
edited
Loading

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is a viewer of log files that are stored in JSON format. It is particularly useful for Java Logback style files. It can highlight and toggle various severities etc.

It adds a context menu item only if the active document is indeed something that can be viewed as JSON formatted log.
In that case, a new tab is opened with a formatted log. Keybindings are only active in this tab.

https://github.com/neno--/LogbackJsonLogViewer

There are no packages like it in Package Control.

packagecontrol-bot
packagecontrol-bot reviewed Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: LogbackJsonLogViewer
Results help

Packages added:
  - LogbackJsonLogViewer

Processing package "LogbackJsonLogViewer"
  - WARNING: The binding ['alt+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['alt+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['alt+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['alt+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+5'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+6'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+7'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+8'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+9'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['super+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['super+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['super+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['super+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+5'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+6'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+7'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+8'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+9'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['alt+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['alt+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['alt+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['alt+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+5'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+6'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+7'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+8'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+9'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap

@braver
Copy link
Collaborator

braver commented Aug 27, 2023

Thanks for your submission, some feedback:

  • You should create the command to open the settings file you mention in the readme, and create a main menu entry as well.
  • Your processing in is_visible is potentially quite heavy. If you're trying to figure out if a file is JSON, why don't you simply read the file's scope (ie. source.json)?

@braver braver added the stale The pull request needs to be updated but has not been within the recent past (2 weeks) label Sep 10, 2023
@braver
Copy link
Collaborator

braver commented Sep 10, 2023

👋🏻

@neno--
Copy link
Contributor Author

neno-- commented Sep 11, 2023

Hello @braver thanks for your feedback:

  • I added the command to open and edit configs. It is available from Settings > Package Settings > LogbackJsonLogViewer menu.
  • I am not processing is_visible anymore. It was an attempt to use heuristics to see if the file was a good candidate for processing. These files would mostly consist of JSON, but some components could add lines that are not JSON. Now users can choose whether they want to view any file with this plugin.

packagecontrol-bot
packagecontrol-bot reviewed Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: LogbackJsonLogViewer
Results help

Packages added:
  - LogbackJsonLogViewer

Processing package "LogbackJsonLogViewer"
  - WARNING: The binding ['super+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['super+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['super+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['super+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+5'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+6'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+7'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+8'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+9'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['alt+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['alt+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['alt+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['alt+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+5'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+6'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+7'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+8'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+9'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['alt+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['alt+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['alt+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['alt+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+5'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+6'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+7'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+8'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+9'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap

@braver braver removed the stale The pull request needs to be updated but has not been within the recent past (2 weeks) label Sep 15, 2023
@braver
Copy link
Collaborator

braver commented Sep 17, 2023

Please look for some examples on how to use edit_settings to open settings in Split View. Having separate menu entries for user and default settings feels like something from the nineties by now 😉

I am not processing is_visible anymore. It was an attempt to use heuristics to see if the file was a good candidate for processing.

Alright. We do like seeing a setting to disable context menu entries. This gives users some control over what shows up in that menu, which tends to get crowded because it's prime real-estate that all packages want to be in. If your package is not something I use every day, I don't need it there. Instead, all commands should be available via the command palette anyway (you might need to add it there still) and that's also the first place people go to look for functionality.

@neno--
Copy link
Contributor Author

neno-- commented Sep 20, 2023

I used the edit_settings command to open plugin settings. Also, added the command to the command palette.

packagecontrol-bot
packagecontrol-bot reviewed Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: LogbackJsonLogViewer
Results help

Packages added:
  - LogbackJsonLogViewer

Processing package "LogbackJsonLogViewer"
  - WARNING: The binding ['alt+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['alt+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['alt+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['alt+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+5'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+6'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+7'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+8'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+9'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['alt+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['alt+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['alt+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['alt+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+5'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+6'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+7'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+8'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+9'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['super+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['super+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['super+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['super+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+5'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+6'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+7'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+8'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+9'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap

@braver
Copy link
Collaborator

braver commented Sep 21, 2023

Alright, that's better 👍🏻

  • Please have a look at the indentation in your keymap files, they look a bit wonky.
  • For main menu entries where you're nesting inside existing entries (e.g. "Package Settings") please only provide the id without the caption (you would actually be overwriting the caption otherwise).
  • Preferably implement a setting to disable the context menu item, since it's now unconditionally visible in all views.

@braver
Copy link
Collaborator

braver commented Nov 19, 2023

👋🏻

@braver braver added the stale The pull request needs to be updated but has not been within the recent past (2 weeks) label Nov 19, 2023
@neno--
Copy link
Contributor Author

neno-- commented Nov 27, 2023

Hello @braver thanks for your feedback. I fixed all three issues.

@braver braver removed the stale The pull request needs to be updated but has not been within the recent past (2 weeks) label Nov 27, 2023
packagecontrol-bot
packagecontrol-bot reviewed Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: LogbackJsonLogViewer
Results help

Packages added:
  - LogbackJsonLogViewer

Processing package "LogbackJsonLogViewer"
  - WARNING: The binding ['alt+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['alt+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['alt+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['alt+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+5'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+6'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+7'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+8'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+9'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['super+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['super+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['super+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['super+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+5'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+6'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+7'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+8'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+9'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['alt+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['alt+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['alt+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['alt+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+5'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+6'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+7'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+8'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+9'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap

@braver
Copy link
Collaborator

braver commented Nov 27, 2023

@neno-- looks good. You still need to tag a new release with those latest changes though.

@braver braver added the stale The pull request needs to be updated but has not been within the recent past (2 weeks) label Dec 16, 2023
@braver
Copy link
Collaborator

braver commented Dec 16, 2023

👋🏻

@neno--
Copy link
Contributor Author

neno-- commented Dec 28, 2023

Hi @braver tag v2.0.0 created: https://github.com/neno--/LogbackJsonLogViewer/releases/tag/v2.0.0

@braver braver removed the stale The pull request needs to be updated but has not been within the recent past (2 weeks) label Dec 29, 2023
packagecontrol-bot
packagecontrol-bot reviewed Dec 29, 2023
View reviewed changes
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: LogbackJsonLogViewer
Results help

Packages added:
  - LogbackJsonLogViewer

Processing package "LogbackJsonLogViewer"
  - WARNING: The binding ['super+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['super+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['super+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['super+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+5'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+6'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+7'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+8'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+9'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['alt+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['alt+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['alt+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['alt+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+5'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+6'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+7'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+8'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+9'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['alt+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['alt+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['alt+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['alt+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+5'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+6'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+7'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+8'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+9'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap

braver
braver requested changes Dec 29, 2023
View reviewed changes
@neno--
Copy link
Contributor Author

neno-- commented Jan 5, 2024

Hi, @braver I added my full name.

packagecontrol-bot
packagecontrol-bot reviewed Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: LogbackJsonLogViewer
Results help

Packages added:
  - LogbackJsonLogViewer

Processing package "LogbackJsonLogViewer"
  - WARNING: The binding ['alt+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['alt+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['alt+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['alt+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+5'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+6'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+7'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+8'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['ctrl+9'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Windows).sublime-keymap
  - WARNING: The binding ['super+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['super+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['super+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['super+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+5'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+6'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+7'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+8'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['ctrl+9'] is also defined in default bindings but is masked with a 'context'
    - File: Default (OSX).sublime-keymap
  - WARNING: The binding ['alt+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['alt+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['alt+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['alt+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+1'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+2'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+3'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+4'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+5'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+6'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+7'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+8'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap
  - WARNING: The binding ['ctrl+9'] is also defined in default bindings but is masked with a 'context'
    - File: Default (Linux).sublime-keymap

@braver braver merged commit d150bfa into wbond:master Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braver braver braver requested changes

@packagecontrol-bot packagecontrol-bot packagecontrol-bot left review comments

Assignees
No one assigned
Labels
feedback provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neno-- @braver @packagecontrol-bot