Skip to content

add pitch_percentage to allow list of parameters #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

yeltnar
Copy link
Contributor

@yeltnar yeltnar commented Apr 8, 2025

Checklist
  • npm test passes (tip: npm run autofix can correct most style issues)
  • tests are included
  • readme and/or JSDoc is updated

Sorry, something went wrong.

@CLAassistant
Copy link

CLAassistant commented Apr 8, 2025

CLA assistant check
All committers have signed the CLA.

@yeltnar
Copy link
Contributor Author

yeltnar commented Apr 8, 2025

This is a beta feature we needed for a project. Thought I would send the change upstream. I realize this is a beta feature so feel free to postpone until it is not beta or disregard all together.

@apaparazzi0329
Copy link
Contributor

This change looks good with me. Could you please sign the CLA and remove the console log from your commit

@acbrant
Copy link
Contributor

acbrant commented Apr 17, 2025

Ok, should be done now. Thanks

@apaparazzi0329 apaparazzi0329 self-requested a review April 17, 2025 15:35
Copy link
Contributor

@apaparazzi0329 apaparazzi0329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apaparazzi0329 apaparazzi0329 merged commit 6650df9 into watson-developer-cloud:master Apr 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants