Skip to content

Commit

Permalink
fix(hand edit): remove trainingStatus from CreateCollection and Updat…
Browse files Browse the repository at this point in the history
…eCollection

these are output parameters and should not be generated in the options model
  • Loading branch information
jeff-arn committed Nov 17, 2020
1 parent d9f1822 commit 370ac3c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 34 deletions.
26 changes: 2 additions & 24 deletions visualrecognitionv4/visual_recognition_v4.go
Original file line number Diff line number Diff line change
Expand Up @@ -281,9 +281,7 @@ func (visualRecognition *VisualRecognitionV4) CreateCollectionWithContext(ctx co
if createCollectionOptions.Description != nil {
body["description"] = createCollectionOptions.Description
}
if createCollectionOptions.TrainingStatus != nil {
body["training_status"] = createCollectionOptions.TrainingStatus
}

_, err = builder.SetBodyContentJSON(body)
if err != nil {
return
Expand Down Expand Up @@ -472,9 +470,7 @@ func (visualRecognition *VisualRecognitionV4) UpdateCollectionWithContext(ctx co
if updateCollectionOptions.Description != nil {
body["description"] = updateCollectionOptions.Description
}
if updateCollectionOptions.TrainingStatus != nil {
body["training_status"] = updateCollectionOptions.TrainingStatus
}

_, err = builder.SetBodyContentJSON(body)
if err != nil {
return
Expand Down Expand Up @@ -1768,9 +1764,6 @@ type CreateCollectionOptions struct {
// The description of the collection.
Description *string `json:"description,omitempty"`

// Training status information for the collection.
TrainingStatus *TrainingStatus `json:"training_status,omitempty"`

// Allows users to set headers on API requests
Headers map[string]string
}
Expand All @@ -1792,12 +1785,6 @@ func (options *CreateCollectionOptions) SetDescription(description string) *Crea
return options
}

// SetTrainingStatus : Allow user to set TrainingStatus
func (options *CreateCollectionOptions) SetTrainingStatus(trainingStatus *TrainingStatus) *CreateCollectionOptions {
options.TrainingStatus = trainingStatus
return options
}

// SetHeaders : Allow user to set Headers
func (options *CreateCollectionOptions) SetHeaders(param map[string]string) *CreateCollectionOptions {
options.Headers = param
Expand Down Expand Up @@ -3097,9 +3084,6 @@ type UpdateCollectionOptions struct {
// The description of the collection.
Description *string `json:"description,omitempty"`

// Training status information for the collection.
TrainingStatus *TrainingStatus `json:"training_status,omitempty"`

// Allows users to set headers on API requests
Headers map[string]string
}
Expand Down Expand Up @@ -3129,12 +3113,6 @@ func (options *UpdateCollectionOptions) SetDescription(description string) *Upda
return options
}

// SetTrainingStatus : Allow user to set TrainingStatus
func (options *UpdateCollectionOptions) SetTrainingStatus(trainingStatus *TrainingStatus) *UpdateCollectionOptions {
options.TrainingStatus = trainingStatus
return options
}

// SetHeaders : Allow user to set Headers
func (options *UpdateCollectionOptions) SetHeaders(param map[string]string) *UpdateCollectionOptions {
options.Headers = param
Expand Down
10 changes: 0 additions & 10 deletions visualrecognitionv4/visual_recognition_v4_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,6 @@ var _ = Describe(`VisualRecognitionV4`, func() {
createCollectionOptionsModel := new(visualrecognitionv4.CreateCollectionOptions)
createCollectionOptionsModel.Name = core.StringPtr("testString")
createCollectionOptionsModel.Description = core.StringPtr("testString")
createCollectionOptionsModel.TrainingStatus = trainingStatusModel
createCollectionOptionsModel.Headers = map[string]string{"x-custom-header": "x-custom-value"}
// Expect response parsing to fail since we are receiving a text/plain response
result, response, operationErr := visualRecognitionService.CreateCollection(createCollectionOptionsModel)
Expand Down Expand Up @@ -584,7 +583,6 @@ var _ = Describe(`VisualRecognitionV4`, func() {
createCollectionOptionsModel := new(visualrecognitionv4.CreateCollectionOptions)
createCollectionOptionsModel.Name = core.StringPtr("testString")
createCollectionOptionsModel.Description = core.StringPtr("testString")
createCollectionOptionsModel.TrainingStatus = trainingStatusModel
createCollectionOptionsModel.Headers = map[string]string{"x-custom-header": "x-custom-value"}

// Invoke operation with valid options model (positive test)
Expand Down Expand Up @@ -644,7 +642,6 @@ var _ = Describe(`VisualRecognitionV4`, func() {
createCollectionOptionsModel := new(visualrecognitionv4.CreateCollectionOptions)
createCollectionOptionsModel.Name = core.StringPtr("testString")
createCollectionOptionsModel.Description = core.StringPtr("testString")
createCollectionOptionsModel.TrainingStatus = trainingStatusModel
createCollectionOptionsModel.Headers = map[string]string{"x-custom-header": "x-custom-value"}
// Invoke operation with empty URL (negative test)
err := visualRecognitionService.SetServiceURL("")
Expand Down Expand Up @@ -1017,7 +1014,6 @@ var _ = Describe(`VisualRecognitionV4`, func() {
updateCollectionOptionsModel.CollectionID = core.StringPtr("testString")
updateCollectionOptionsModel.Name = core.StringPtr("testString")
updateCollectionOptionsModel.Description = core.StringPtr("testString")
updateCollectionOptionsModel.TrainingStatus = trainingStatusModel
updateCollectionOptionsModel.Headers = map[string]string{"x-custom-header": "x-custom-value"}
// Expect response parsing to fail since we are receiving a text/plain response
result, response, operationErr := visualRecognitionService.UpdateCollection(updateCollectionOptionsModel)
Expand Down Expand Up @@ -1113,7 +1109,6 @@ var _ = Describe(`VisualRecognitionV4`, func() {
updateCollectionOptionsModel.CollectionID = core.StringPtr("testString")
updateCollectionOptionsModel.Name = core.StringPtr("testString")
updateCollectionOptionsModel.Description = core.StringPtr("testString")
updateCollectionOptionsModel.TrainingStatus = trainingStatusModel
updateCollectionOptionsModel.Headers = map[string]string{"x-custom-header": "x-custom-value"}

// Invoke operation with valid options model (positive test)
Expand Down Expand Up @@ -1174,7 +1169,6 @@ var _ = Describe(`VisualRecognitionV4`, func() {
updateCollectionOptionsModel.CollectionID = core.StringPtr("testString")
updateCollectionOptionsModel.Name = core.StringPtr("testString")
updateCollectionOptionsModel.Description = core.StringPtr("testString")
updateCollectionOptionsModel.TrainingStatus = trainingStatusModel
updateCollectionOptionsModel.Headers = map[string]string{"x-custom-header": "x-custom-value"}
// Invoke operation with empty URL (negative test)
err := visualRecognitionService.SetServiceURL("")
Expand Down Expand Up @@ -3927,12 +3921,10 @@ var _ = Describe(`VisualRecognitionV4`, func() {
createCollectionOptionsModel := visualRecognitionService.NewCreateCollectionOptions()
createCollectionOptionsModel.SetName("testString")
createCollectionOptionsModel.SetDescription("testString")
createCollectionOptionsModel.SetTrainingStatus(trainingStatusModel)
createCollectionOptionsModel.SetHeaders(map[string]string{"foo": "bar"})
Expect(createCollectionOptionsModel).ToNot(BeNil())
Expect(createCollectionOptionsModel.Name).To(Equal(core.StringPtr("testString")))
Expect(createCollectionOptionsModel.Description).To(Equal(core.StringPtr("testString")))
Expect(createCollectionOptionsModel.TrainingStatus).To(Equal(trainingStatusModel))
Expect(createCollectionOptionsModel.Headers).To(Equal(map[string]string{"foo": "bar"}))
})
It(`Invoke NewDeleteCollectionOptions successfully`, func() {
Expand Down Expand Up @@ -4156,13 +4148,11 @@ var _ = Describe(`VisualRecognitionV4`, func() {
updateCollectionOptionsModel.SetCollectionID("testString")
updateCollectionOptionsModel.SetName("testString")
updateCollectionOptionsModel.SetDescription("testString")
updateCollectionOptionsModel.SetTrainingStatus(trainingStatusModel)
updateCollectionOptionsModel.SetHeaders(map[string]string{"foo": "bar"})
Expect(updateCollectionOptionsModel).ToNot(BeNil())
Expect(updateCollectionOptionsModel.CollectionID).To(Equal(core.StringPtr("testString")))
Expect(updateCollectionOptionsModel.Name).To(Equal(core.StringPtr("testString")))
Expect(updateCollectionOptionsModel.Description).To(Equal(core.StringPtr("testString")))
Expect(updateCollectionOptionsModel.TrainingStatus).To(Equal(trainingStatusModel))
Expect(updateCollectionOptionsModel.Headers).To(Equal(map[string]string{"foo": "bar"}))
})
It(`Invoke NewUpdateObjectMetadata successfully`, func() {
Expand Down

0 comments on commit 370ac3c

Please sign in to comment.