feat: WASI 0.2.2 #3312
Merged
feat: WASI 0.2.2 #3312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvolosatovs
force-pushed
the
feat/wasi-0.2.2
branch
from
42a19ab to
786ee78
Compare
ricochet
reviewed
Oct 14, 2024
brooksmtownsend
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
From what I understand, looks like
- wasmcloud_component now will use
wasi:config/store.* - wasmcloud_runtime supports
wasi:config/store|runtime.*(for the time being)
As long as I'm right there, LGTM. Left a suggestion for the test to "verify" backwards compatibility isn't carelessly removed in a future commit but I'm open to options
Bumps [wasi](https://github.com/bytecodealliance/wasi-rs) from 0.13.2+wasi-0.2.1 to 0.13.3+wasi-0.2.2. - [Commits](bytecodealliance/wasi-rs@0.13.2...0.13.3) --- updated-dependencies: - dependency-name: wasi dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Roman Volosatovs <[email protected]>
rvolosatovs
force-pushed
the
feat/wasi-0.2.2
branch
from
786ee78 to
f4998f6
Compare
That's exactly right, I've added a test case for the legacy interface in 51ea896 |
rvolosatovs
force-pushed
the
feat/wasi-0.2.2
branch
from
f4998f6 to
715a417
Compare
Signed-off-by: Roman Volosatovs <[email protected]>
rvolosatovs
force-pushed
the
feat/wasi-0.2.2
branch
from
715a417 to
51ea896
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
wasmcloud_componentto use WASI 0.2.2wasi:config/storeRelated Issues
#3253
WebAssembly/wasi-config#14
WebAssembly/wasi-blobstore#28
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification