Skip to content

Copied APC support logic #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2025
Merged

Copied APC support logic #1

merged 1 commit into from
Feb 5, 2025

Conversation

SohamP2812
Copy link

@SohamP2812 SohamP2812 commented Feb 5, 2025 •
edited
Loading

@SohamP2812 SohamP2812 requested a review from heysweet February 5, 2025 19:30
@SohamP2812
Copy link
Author

Does it make sense that we don't have to merge this and can just use this commit as our vte package?

heysweet
heysweet approved these changes Feb 5, 2025
View reviewed changes
Copy link

@heysweet heysweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, this is the same as the original PR

@heysweet
Copy link

heysweet commented Feb 5, 2025

Yeah let's just not merge this PR

@SohamP2812 SohamP2812 changed the base branch from master to warpdotdev/v0.13.0 February 5, 2025 20:23
@SohamP2812
Copy link
Author

Ignore comments referring to not merging. Now using a versioned branch system for this fork, so we can merge

@SohamP2812 SohamP2812 merged commit 4b399c8 into warpdotdev/v0.13.0 Feb 5, 2025
@vorporeal vorporeal deleted the copied-apc-support branch February 5, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heysweet heysweet heysweet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SohamP2812 @heysweet