Skip to content

Harden review-pr prompt to prevent agent from calling gh pr review #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
captainsafia merged 1 commit into from
Feb 25, 2026
Merged

Harden review-pr prompt to prevent agent from calling gh pr review #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/review-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ jobs:
- Working directory is PR branch.
- You have access to the full source code, but you should primarily analyze and comment on the diff below
- **Restrict feedback to code modified in this PR and its immediate context**. Do not comment on untouched files or lines (GitHub will reject these comments). If you must mention issues in untouched code, add them to the summary instead
- **CRITICAL: DO NOT run \`gh pr review\`, \`gh pr comment\`, or any \`gh\` command that posts to GitHub. You must NOT submit any GitHub review or comment directly. All output must be written to \`review.json\` only—the Post Review step will handle publishing.**

## PR Context

Expand Down Expand Up @@ -187,8 +188,9 @@ jobs:
### 7. Final Step

- Create \`review.json\` with your drafted content
- Validate JSON with \`jq\`. If this fails, update the \`review.json\` file with the correct JSON. Do not attempt to use \`rm\`
- Validate JSON with \`jq\`. If this fails, update the \`review.json\` file with the correct JSON. Do not attempt to use \`rm\`
- Ensure line numbers are correct and match the diff
- **DO NOT run \`gh pr review\`, \`gh pr comment\`, \`gh api\`, or any other command that posts content to GitHub. Your only output is \`review.json\`. Stop after validating the file.**

---

Expand Down Expand Up @@ -246,6 +248,7 @@ jobs:
- [ ] Comment spans are ≤10 lines (\`line - start_line <= 10\`)
- [ ] Summary includes issue counts and recommendation
- [ ] JSON is valid, use \`jq\` to validate
- [ ] No \`gh pr review\`, \`gh pr comment\`, or other GitHub-posting commands were run

**Goal**: Provide actionable, high-signal feedback to help the author improve the code. Be direct and specific.
`;
Expand Down
5 changes: 4 additions & 1 deletion examples/review-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ jobs:
- Working directory is PR branch.
- You have access to the full source code, but you should primarily analyze and comment on the diff below
- **Restrict feedback to code modified in this PR and its immediate context**. Do not comment on untouched files or lines (GitHub will reject these comments). If you must mention issues in untouched code, add them to the summary instead
- **CRITICAL: DO NOT run \`gh pr review\`, \`gh pr comment\`, or any \`gh\` command that posts to GitHub. You must NOT submit any GitHub review or comment directly. All output must be written to \`review.json\` only—the Post Review step will handle publishing.**

## PR Context

Expand Down Expand Up @@ -179,8 +180,9 @@ jobs:
### 7. Final Step

- Create \`review.json\` with your drafted content
- Validate JSON with \`jq\`. If this fails, update the \`review.json\` file with the correct JSON. Do not attempt to use \`rm\`
- Validate JSON with \`jq\`. If this fails, update the \`review.json\` file with the correct JSON. Do not attempt to use \`rm\`
- Ensure line numbers are correct and match the diff
- **DO NOT run \`gh pr review\`, \`gh pr comment\`, \`gh api\`, or any other command that posts content to GitHub. Your only output is \`review.json\`. Stop after validating the file.**

---

Expand Down Expand Up @@ -238,6 +240,7 @@ jobs:
- [ ] Comment spans are ≤10 lines (\`line - start_line <= 10\`)
- [ ] Summary includes issue counts and recommendation
- [ ] JSON is valid, use \`jq\` to validate
- [ ] No \`gh pr review\`, \`gh pr comment\`, or other GitHub-posting commands were run

**Goal**: Provide actionable, high-signal feedback to help the author improve the code. Be direct and specific.
`;
Expand Down