Skip to content

Add git update-ref completions#286

Open
SkyNotSilent wants to merge 1 commit into
warpdotdev:mainfrom
SkyNotSilent:codex/add-git-update-ref-completions
Open

Add git update-ref completions#286
SkyNotSilent wants to merge 1 commit into
warpdotdev:mainfrom
SkyNotSilent:codex/add-git-update-ref-completions

Conversation

@SkyNotSilent

@SkyNotSilent SkyNotSilent commented Jun 22, 2026

Copy link
Copy Markdown

Summary

  • add a git update-ref completion spec with refs, values, and supported options
  • add a reusable refs generator that completes full refs/... names from git for-each-ref
  • cover ref post-processing with a unit test

Closes #287.
Addresses warpdotdev/warp#12322.

Testing

  • npm run format:check -- command-signatures/json/git.json
  • cargo fmt --check
  • cargo test -p warp-command-signatures git::tests::test_post_process_refs
  • cargo test -p warp-command-signatures
  • cargo test
  • cargo clippy --workspace --all-targets -- -D warnings
  • script/presubmit
  • manual temp repo check: git for-each-ref --format="%(refname)" --sort="refname" "refs/**" includes refs/remotes/origin/main

Notes

  • No Warp GUI screenshot included; this change is in the command-signatures package and is covered by generator/spec validation plus a manual git refs check.

@cla-bot

cla-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: mima1234.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@oz-for-oss

oz-for-oss Bot commented Jun 22, 2026

Copy link
Copy Markdown

@SkyNotSilent

Every PR must be linked to a same-repo issue before Oz can review it.

This PR is linked to #287, but no linked issue is marked ready-to-implement yet. Only repository maintainers apply that label, so please wait for a maintainer to mark the issue. Once it is marked, push a new commit or comment /oz-review to re-trigger review.

Powered by Oz

oz-for-oss[bot]
oz-for-oss Bot previously requested changes Jun 22, 2026

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SkyNotSilent

Every PR must be linked to a same-repo issue before Oz can review it.

Next step: open or find a same-repo issue describing this change, then link it to this PR by adding Closes #123 to the PR description (or using the "Development" sidebar on GitHub). A maintainer will mark the issue ready-to-implement when it is ready. Once it is marked, comment /oz-review to re-trigger review.

Powered by Oz

@SkyNotSilent SkyNotSilent force-pushed the codex/add-git-update-ref-completions branch from ede856c to 1ea1214 Compare June 22, 2026 07:51
@cla-bot cla-bot Bot added the cla-signed label Jun 22, 2026
@SkyNotSilent

Copy link
Copy Markdown
Author

/oz-review

oz-for-oss[bot]
oz-for-oss Bot previously requested changes Jun 22, 2026

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SkyNotSilent

Every PR must be linked to a same-repo issue before Oz can review it.

This PR is linked to #287, but no linked issue is marked ready-to-implement yet. Only repository maintainers apply that label, so please wait for a maintainer to mark the issue. Once it is marked, push a new commit or comment /oz-review to re-trigger review.

Powered by Oz

@acarl005

Copy link
Copy Markdown
Contributor

/oz-review

@acarl005 acarl005 self-assigned this Jul 10, 2026
@oz-for-oss

oz-for-oss Bot commented Jul 10, 2026

Copy link
Copy Markdown

@acarl005

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I reviewed this pull request and requested human review from: @acarl005.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@acarl005

Copy link
Copy Markdown
Contributor

@SkyNotSilent Sorry this one fell through the cracks! I added the label the bot needed so now we're good to push this forward.

@oz-for-oss oz-for-oss Bot dismissed stale reviews from themself July 10, 2026 14:26

Oz no longer requests changes for this pull request after the latest automated review.

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

Adds a git update-ref command signature plus a reusable refs generator for completing full refs/... names. The generator output is deduplicated, filtered, and covered by a focused unit test.

Concerns

No blocking concerns found. No approved spec context was available for this PR, and the security pass did not identify security-relevant issues in the changed lines.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot requested a review from acarl005 July 10, 2026 14:26

@acarl005 acarl005 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the group --deref / --no-deref they differ from the other boolean pairs.

--stdin/--no-stdin and --create-reflog/--no-create-reflog are each a single entry with an array name field. --deref and --no-deref follow the same --[no-] pattern but are listed as two separate entries. For consistency:

{
    "name": ["--no-deref", "--deref"],
    "description": "Update the ref itself instead of the one it points to (default: follow symrefs)"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add git update-ref completions

2 participants