Add git update-ref completions#286
Conversation
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: mima1234.
|
|
Every PR must be linked to a same-repo issue before Oz can review it. This PR is linked to #287, but no linked issue is marked Powered by Oz |
There was a problem hiding this comment.
Every PR must be linked to a same-repo issue before Oz can review it.
Next step: open or find a same-repo issue describing this change, then link it to this PR by adding Closes #123 to the PR description (or using the "Development" sidebar on GitHub). A maintainer will mark the issue ready-to-implement when it is ready. Once it is marked, comment /oz-review to re-trigger review.
Powered by Oz
ede856c to
1ea1214
Compare
|
/oz-review |
There was a problem hiding this comment.
Every PR must be linked to a same-repo issue before Oz can review it.
This PR is linked to #287, but no linked issue is marked ready-to-implement yet. Only repository maintainers apply that label, so please wait for a maintainer to mark the issue. Once it is marked, push a new commit or comment /oz-review to re-trigger review.
Powered by Oz
|
/oz-review |
|
I'm re-reviewing this pull request in response to a review request. You can view the conversation on Warp. I reviewed this pull request and requested human review from: Comment Powered by Oz |
|
@SkyNotSilent Sorry this one fell through the cracks! I added the label the bot needed so now we're good to push this forward. |
Oz no longer requests changes for this pull request after the latest automated review.
There was a problem hiding this comment.
Overview
Adds a git update-ref command signature plus a reusable refs generator for completing full refs/... names. The generator output is deduplicated, filtered, and covered by a focused unit test.
Concerns
No blocking concerns found. No approved spec context was available for this PR, and the security pass did not identify security-relevant issues in the changed lines.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
There was a problem hiding this comment.
For the group --deref / --no-deref they differ from the other boolean pairs.
--stdin/--no-stdin and --create-reflog/--no-create-reflog are each a single entry with an array name field. --deref and --no-deref follow the same --[no-] pattern but are listed as two separate entries. For consistency:
{
"name": ["--no-deref", "--deref"],
"description": "Update the ref itself instead of the one it points to (default: follow symrefs)"
}
Summary
git update-refcompletion spec with refs, values, and supported optionsrefsgenerator that completes fullrefs/...names fromgit for-each-refCloses #287.
Addresses warpdotdev/warp#12322.
Testing
npm run format:check -- command-signatures/json/git.jsoncargo fmt --checkcargo test -p warp-command-signatures git::tests::test_post_process_refscargo test -p warp-command-signaturescargo testcargo clippy --workspace --all-targets -- -D warningsscript/presubmitgit for-each-ref --format="%(refname)" --sort="refname" "refs/**"includesrefs/remotes/origin/mainNotes