Fix #292: Add server-specific channel statistics #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for server-specific channel statistics to prevent information leakage between different server instances running on the same host. The issue was that the published_messages and stored_messages counters were stored in a shared memory segment that is shared across all server instances running on the same host. When a user requests channel statistics from one server instance, they were seeing the combined statistics from all server instances, which could leak information. Changes: - Added a new directive push_stream_server_id to set a unique identifier for each server instance - Added server-specific counters for published_messages and stored_messages - Modified the channel statistics handler to use the server-specific counters when available - Updated the documentation to include the new directive This fix ensures that each server instance only reports its own statistics, preventing information leakage between different server instances.
|
您的信已收到，我将尽快给您答复
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for server-specific channel statistics to prevent information leakage between different server instances running on the same host.
The issue was that the published_messages and stored_messages counters were stored in a shared memory segment that is shared across all server instances running on the same host. When a user requests channel statistics from one server instance, they were seeing the combined statistics from all server instances, which could leak information.
Changes:
This fix ensures that each server instance only reports its own statistics, preventing information leakage between different server instances.
Addresses: #292
cc: @wandenberg