feat(fs-router): page parts added #1318
Conversation
to come after #1313
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
| createPagePart({ | ||
| path, | ||
| component: mod.default, | ||
| render: 'static', |
There was a problem hiding this comment.
It feels like we should make "render: 'static'" by default for createPage.
There was a problem hiding this comment.
So nextjs actually used this default and had a lot of user issues with it. Next 15 made pages dynamic by default (by popular demand): link to announcement
I should make the pagePart default render be dynamic. It matches what seems to be intuitive for users.
Maybe we should make layouts dynamic by default as well if we want consistency though?
There was a problem hiding this comment.
Maybe we should make layouts dynamic by default as well if we want consistency though?
That sounds better for consistency.
Though, this is still a simple rule:
- layout, root: static by default
- page, page parts: dynamic by default
Hm, I may prefer everything dynamic or static by default. Let's discuss with @sandren after we finish v0.22.
to come after #1313