Skip to content

Conversation

Kyrela
Copy link
Collaborator

@Kyrela Kyrela commented Dec 31, 2023

This PR update the package to be up-to-date with the latest discord markdown flavor

@Kyrela Kyrela marked this pull request as draft April 20, 2024 16:16
@Kyrela
Copy link
Collaborator Author

Kyrela commented Apr 20, 2024

The URL_REGEX regex is a regex bomb. I still need to find a better one and test it properly. (Kyrela#1)

@Kyrela Kyrela marked this pull request as ready for review September 20, 2024 22:21
@Kyrela
Copy link
Collaborator Author

Kyrela commented Sep 20, 2024

Tested on production environment for two weeks now, seems to be perfectly working. Ready for review.

@w4rum
Copy link
Owner

w4rum commented Oct 27, 2024

@Kyrela

Sorry for not getting back to you on this. I'm not actively working on this project anymore. Since you're interested in this, how about I add you as a collaborator and you can just adopt this project and merge the changes yourself?

@Kyrela
Copy link
Collaborator Author

Kyrela commented Oct 27, 2024

Hi, not sure if I'm the most relevant person to be a collaborator (I just fixed a few issues, @Vioshim is the author of 90% of the changes), but as I'm relying on this package for some of my projects, I'll necessarily have to maintain it in any case, so I'd be happy to accept.

PS: I don't think he'd be interested, given that his fork looks abandoned (Vioshim#2), but it would be interesting to also offer @Vioshim to contribute to the project.

@Vioshim
Copy link
Collaborator

Vioshim commented Oct 28, 2024

My apologies for the lack of response, never got notifications about it in my email until now, I'll be looking into this, thanks for the patience.

Edit: I'm more than glad to still help and continue the project

@Kyrela
Copy link
Collaborator Author

Kyrela commented Oct 28, 2024

@w4rum can you perhaps add @Vioshim as a collaborator?

@Kyrela Kyrela force-pushed the master branch 2 times, most recently from 300b6a3 to c88ec3f Compare October 28, 2024 21:14
@w4rum
Copy link
Owner

w4rum commented Dec 14, 2024

@Kyrela Sorry for the delay.

I added @Vioshim as a collaborator. Hey, @Vioshim!

@Kyrela
Copy link
Collaborator Author

Kyrela commented Dec 14, 2024

Thanks! Not merging anything for now as there isn't any caption (-#) #5 and email links #8 support, and the quote support has big false positives, both on #2 and #4.

I'm working on it, but it's not my priority so the progression is quite slow.

@Kyrela Kyrela changed the base branch from master to v2 December 14, 2024 21:55
@Kyrela Kyrela marked this pull request as draft December 14, 2024 23:20
@Kyrela Kyrela self-assigned this May 5, 2025
@Kyrela Kyrela added the enhancement New feature or request label May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants