Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ“¦ Release @webref/[email protected] #716

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 29, 2022

⚠ NEVER add commits to this pull request.

πŸ€– This pull request was automatically created to facilitate human review of @webref/idl changes triggered by curated data at 8f537c6.

🧐 Please review the diff below and version numbers. If all looks good, merge this pull request to release the changes to npm.

πŸ“¦ Latest released @webref/idl package was v3.14.0. Merging this pull request will release v3.15.0. Make sure that the bump is the right one for the changes.

✍ If any change needs to be made before release, do not add a commit to this pull request. Changes should rather be handled in a separate pull request and pushed to the main branch. You may leave this pull request open in the meantime, or close it. The pre-release job will automatically update this pull request or create a new one once the updates have made their way to the main branch.

πŸ›ˆ The actual change introduced by this pull request is a version bump in packages/idl/package.json. You do not need to review that change. The bumped version is not the version that will be released when this pull request is merged, but rather the version that will be released next time.

diff --ignore-trailing-space '--exclude=package.json' '--exclude=README.md' '--unified=3' webref/node_modules/@webref/idl/html.idl packages/idl/html.idl
--- webref/node_modules/@webref/idl/html.idl
+++ packages/idl/html.idl
@@ -1364,14 +1364,7 @@
 
 interface mixin CanvasFilters {
   // filters
-  attribute (DOMString or CanvasFilter) filter; // (default "none")
-};
-
-typedef record<DOMString, any> CanvasFilterInput;
-
-[Exposed=(Window,Worker,PaintWorklet)]
-interface CanvasFilter {
-  constructor(optional (CanvasFilterInput or sequence<CanvasFilterInput>) filters);
+  attribute DOMString filter; // (default "none")
 };
 
 interface mixin CanvasRect {

diff --ignore-trailing-space '--exclude=package.json' '--exclude=README.md' '--unified=3' webref/node_modules/@webref/idl/mediacapture-viewport.idl packages/idl/mediacapture-viewport.idl
--- webref/node_modules/@webref/idl/mediacapture-viewport.idl
+++ packages/idl/mediacapture-viewport.idl
@@ -5,5 +5,10 @@
 
 partial interface MediaDevices {
   Promise<MediaStream> getViewportMedia(
-      optional DisplayMediaStreamConstraints constraints = {});
+      optional ViewportMediaStreamConstraints constraints = {});
+};
+
+dictionary ViewportMediaStreamConstraints {
+  (boolean or MediaTrackConstraints) video = true;
+  (boolean or MediaTrackConstraints) audio = false;
 };

diff --ignore-trailing-space '--exclude=package.json' '--exclude=README.md' '--unified=3' webref/node_modules/@webref/idl/screen-capture.idl packages/idl/screen-capture.idl
--- webref/node_modules/@webref/idl/screen-capture.idl
+++ packages/idl/screen-capture.idl
@@ -4,7 +4,7 @@
 // Source: Screen Capture (https://w3c.github.io/mediacapture-screen-share/)
 
 partial interface MediaDevices {
-  Promise<MediaStream> getDisplayMedia(optional DisplayMediaStreamConstraints constraints = {});
+  Promise<MediaStream> getDisplayMedia(optional DisplayMediaStreamOptions options = {});
 };
 
 enum SelfCapturePreferenceEnum {
@@ -22,7 +22,7 @@
   "exclude"
 };
 
-dictionary DisplayMediaStreamConstraints {
+dictionary DisplayMediaStreamOptions {
   (boolean or MediaTrackConstraints) video = true;
   (boolean or MediaTrackConstraints) audio = false;
   SelfCapturePreferenceEnum selfBrowserSurface;

diff --ignore-trailing-space '--exclude=package.json' '--exclude=README.md' '--unified=3' webref/node_modules/@webref/idl/secure-payment-confirmation.idl packages/idl/secure-payment-confirmation.idl
--- webref/node_modules/@webref/idl/secure-payment-confirmation.idl
+++ packages/idl/secure-payment-confirmation.idl
@@ -22,7 +22,7 @@
   boolean isPayment;
 
   // Only used for authentication.
-  USVString rp;
+  USVString rpId;
   USVString topOrigin;
   DOMString payeeName;
   USVString payeeOrigin;
@@ -35,7 +35,7 @@
 };
 
 dictionary CollectedClientAdditionalPaymentData {
-    required USVString rp;
+    required USVString rpId;
     required USVString topOrigin;
     DOMString payeeName;
     USVString payeeOrigin;

diff --ignore-trailing-space '--exclude=package.json' '--exclude=README.md' '--unified=3' webref/node_modules/@webref/idl/webgpu.idl packages/idl/webgpu.idl
--- webref/node_modules/@webref/idl/webgpu.idl
+++ packages/idl/webgpu.idl
@@ -18,6 +18,7 @@
     readonly attribute unsigned long maxTextureDimension3D;
     readonly attribute unsigned long maxTextureArrayLayers;
     readonly attribute unsigned long maxBindGroups;
+    readonly attribute unsigned long maxBindingsPerBindGroup;
     readonly attribute unsigned long maxDynamicUniformBuffersPerPipelineLayout;
     readonly attribute unsigned long maxDynamicStorageBuffersPerPipelineLayout;
     readonly attribute unsigned long maxSampledTexturesPerShaderStage;
@@ -30,11 +31,13 @@
     readonly attribute unsigned long minUniformBufferOffsetAlignment;
     readonly attribute unsigned long minStorageBufferOffsetAlignment;
     readonly attribute unsigned long maxVertexBuffers;
+    readonly attribute unsigned long long maxBufferSize;
     readonly attribute unsigned long maxVertexAttributes;
     readonly attribute unsigned long maxVertexBufferArrayStride;
     readonly attribute unsigned long maxInterStageShaderComponents;
     readonly attribute unsigned long maxInterStageShaderVariables;
     readonly attribute unsigned long maxColorAttachments;
+    readonly attribute unsigned long maxColorAttachmentBytesPerPixel;
     readonly attribute unsigned long maxComputeWorkgroupStorageSize;
     readonly attribute unsigned long maxComputeInvocationsPerWorkgroup;
     readonly attribute unsigned long maxComputeWorkgroupSizeX;
@@ -1188,7 +1191,7 @@
         DOMString type,
         GPUUncapturedErrorEventInit gpuUncapturedErrorEventInitDict
     );
-    readonly attribute GPUError error;
+    [SameObject] readonly attribute GPUError error;
 };
 
 dictionary GPUUncapturedErrorEventInit : EventInit {

diff --ignore-trailing-space '--exclude=package.json' '--exclude=README.md' '--unified=3' webref/node_modules/@webref/idl/webnn.idl packages/idl/webnn.idl
--- webref/node_modules/@webref/idl/webnn.idl
+++ packages/idl/webnn.idl
@@ -31,26 +31,20 @@
   MLContext createContext(GPUDevice gpuDevice);
 };
 
-dictionary MLArrayInput {
-  required ArrayBufferView resource;
-  required sequence<long> dimensions;
-};
-
-typedef record<DOMString, (ArrayBufferView or MLArrayInput)> MLNamedArrayInputs;
-typedef record<DOMString, ArrayBufferView> MLNamedArrayOutputs;
+typedef record<DOMString, ArrayBufferView> MLNamedArrayBufferViews;
 
 [SecureContext, Exposed=(Window, DedicatedWorker)]
 interface MLContext {};
 
 partial interface MLContext {
   [Exposed=(DedicatedWorker)]
-  undefined compute(MLGraph graph, MLNamedArrayInputs inputs, MLNamedArrayOutputs outputs);
+  undefined compute(
+      MLGraph graph, MLNamedArrayBufferViews inputs, MLNamedArrayBufferViews outputs);
 };
 
 partial interface MLContext {
-  Promise<undefined> computeAsync(MLGraph graph, MLNamedArrayInputs inputs,
-
-                    MLNamedArrayOutputs outputs);
+  Promise<undefined> computeAsync(
+      MLGraph graph, MLNamedArrayBufferViews inputs, MLNamedArrayBufferViews outputs);
 };
 
 partial interface MLContext {
@@ -76,8 +70,7 @@
   required MLOperandType type;
 
   // The dimensions field is only required for tensor operands.
-  // The negative value means an unknown dimension.
-  sequence<long> dimensions;
+  sequence<unsigned long> dimensions;
 };
 
 [SecureContext, Exposed=(Window, DedicatedWorker)]
@@ -484,13 +477,7 @@
 
 typedef (GPUBuffer or GPUTexture) MLGPUResource;
 
-dictionary MLGPUInput {
-  required MLGPUResource resource;
-  required sequence<long> dimensions;
-};
-
-typedef record<DOMString, (MLGPUResource or MLGPUInput)> MLNamedGPUInputs;
-typedef record<DOMString, MLGPUResource> MLNamedGPUOutputs;
+typedef record<DOMString, MLGPUResource> MLNamedGPUResources;
 
 [SecureContext, Exposed=(Window, DedicatedWorker)]
 interface MLCommandEncoder {};
@@ -500,7 +487,7 @@
 };
 
 partial interface MLCommandEncoder {
-  undefined dispatch(MLGraph graph, MLNamedGPUInputs inputs, MLNamedGPUOutputs outputs);
+  undefined dispatch(MLGraph graph, MLNamedGPUResources inputs, MLNamedGPUResources outputs);
 };
 
 partial interface MLCommandEncoder {

diff --ignore-trailing-space '--exclude=package.json' '--exclude=README.md' '--unified=3' webref/node_modules/@webref/idl/webxr.idl packages/idl/webxr.idl
--- webref/node_modules/@webref/idl/webxr.idl
+++ packages/idl/webxr.idl
@@ -23,8 +23,8 @@
 };
 
 dictionary XRSessionInit {
-  sequence<any> requiredFeatures;
-  sequence<any> optionalFeatures;
+  sequence<DOMString> requiredFeatures;
+  sequence<DOMString> optionalFeatures;
 };
 
 enum XRVisibilityState {
@@ -40,6 +40,7 @@
   readonly attribute Float32Array? supportedFrameRates;
   [SameObject] readonly attribute XRRenderState renderState;
   [SameObject] readonly attribute XRInputSourceArray inputSources;
+  readonly attribute FrozenArray<DOMString> enabledFeatures;
 
   // Methods
   undefined updateRenderState(optional XRRenderStateInit state = {});
@@ -283,11 +284,11 @@
 
 dictionary XRPermissionDescriptor: PermissionDescriptor {
   XRSessionMode mode;
-  sequence<any> requiredFeatures;
-  sequence<any> optionalFeatures;
+  sequence<DOMString> requiredFeatures;
+  sequence<DOMString> optionalFeatures;
 };
 
 [Exposed=Window]
 interface XRPermissionStatus: PermissionStatus {
-  attribute FrozenArray<any> granted;
+  attribute FrozenArray<DOMString> granted;
 };

@dontcallmedom
Copy link
Member

+ [SameObject] required GPUError error;

Μ€[SameObject]` is only meant to be used on attributes, not on dictionary members.

This was re-added 2 days ago after having been removed in December 2021 - it's not clear to me that the fact that GPUError is an interface means that extended attribute newly makes sense in a dictionary. I guess gpuweb/gpuweb#1225 should be re-opened?

@dontcallmedom
Copy link
Member

also, maybe a check to add to our extended attribute validation rules?

@github-actions github-actions bot force-pushed the release-idl-20220829110503266 branch from 39e4433 to 8d03ca3 Compare August 29, 2022 12:48
@dontcallmedom
Copy link
Member

This was re-added 2 days ago after having been removed in December 2021 - it's not clear to me that the fact that GPUError is an interface means that extended attribute newly makes sense in a dictionary.

I now understand - the extended attribute had been removed from the GPUUncapturedErrorEvent interface pending the conversion of GPUError to an interface, but was (mistakenly) readded to the GPUUncapturedErrorEventInit dictionary - I'll file a PR

@dontcallmedom
Copy link
Member

filed at gpuweb/gpuweb#3385

@tidoust
Copy link
Member

tidoust commented Aug 29, 2022

also, maybe a check to add to our extended attribute validation rules?

... or these checks could perhaps be enforced by the WebIDL parser directly. That seems to be in scope of w3c/webidl2.js#570

@github-actions github-actions bot force-pushed the release-idl-20220829110503266 branch 3 times, most recently from 7fdaa5f to 3188c6e Compare August 30, 2022 06:52
@dontcallmedom
Copy link
Member

WebGPU bug now fixed

@github-actions github-actions bot force-pushed the release-idl-20220829110503266 branch from 3188c6e to fc7a327 Compare August 30, 2022 12:52
@tidoust tidoust merged commit c68c91c into main Aug 30, 2022
@tidoust tidoust deleted the release-idl-20220829110503266 branch August 30, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants