Proposal: SecurityInfo in WebRequest
#899
Open
+193
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philwo
pushed a commit
to philwo/chromium
that referenced
this pull request
Nov 6, 2025
This change allows to get ssl_info in TrustedHeaderClient, which is used by url_loader and web_socket. The change won't impact performance of url_loader or web_socket, that does not use trusted_headers_client, which is only used in two places, and this is where ssl_info is needed for extensions api in future: extensions/browser/api/web_request/web_request_proxying_websocket.cc extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc Extensions proposal: w3c/webextensions#899 Isolated Web App API proposal: explainers-by-googlers/security-info-web-request#1 I have added low coverage reason because websocket.cc is not tested via unit tests, but with chrome/browser/net/websocket_browsertest.cc. It is out of scope of my CL to investigate why unit tests are absent for websocket.cc. Change-Id: I40f0fcb40db7a5efeaaf18276d6cc9bf6c7b48e3 Bug: 458045659 Low-Coverage-Reason: HARD_TO_TEST Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7106780 Reviewed-by: Adam Rice <[email protected]> Reviewed-by: Arthur Sonzogni <[email protected]> Reviewed-by: Finnur Thorarinsson <[email protected]> Reviewed-by: Andrew Rayskiy <[email protected]> Commit-Queue: Vlad Krot <[email protected]> Cr-Commit-Position: refs/heads/main@{#1541131}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposal following discussion at #882