Skip to content

Conversation

sadym-chromium
Copy link
Contributor

@sadym-chromium sadym-chromium commented Aug 29, 2025

Addressing #1920.

Currently, WebDriver capabilities allow for configuring proxy by protocol. Meaning the protocol traffic can be proxied via the same protocol proxy.

Chromium can proxy traffic via different proxy protocols, and can configure which proxy to use for which protocol. In Chromium, the possible proxy schemas are http, https, socks4, socks5. Also user can configure separately proxy for HTTP, HTTPS and all other requests (SOCKS).

In order to allow for such configurations, we propose the following:

  • Allow for schemas (http, https, socks4, socks5) in the proxy url.
  • Deprecate socks in favor of other proxy configuration.

Preview | Diff

@sadym-chromium sadym-chromium requested a review from OrKoN August 29, 2025 15:01
@sadym-chromium sadym-chromium changed the title Align "proxy" string configuration with Chromium implementation Allow for "proxy" schemas Aug 29, 2025
@sadym-chromium sadym-chromium changed the title Allow for "proxy" schemas Allow for specifying schema in "proxy" Aug 29, 2025
@sadym-chromium sadym-chromium marked this pull request as ready for review August 29, 2025 15:33
Copy link
Contributor

@OrKoN OrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

index.html Outdated
undefined.

<p>A <dfn>proxy schema</dfn> is defined as being one of the following strings:
"<code>http</code>", "<code>https</code>", "<code>socks4</code>",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither socks4 nor socks5 is a valid schema as supported by Firefox. For socks proxy there is usually no schema at all when specifying the host. Does Chrome support that? Also note the other comment above regarding the backward incompatible change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As documented here, Chrome supports proxy via HTTP, SSL, SOCKS 4 and SOCKS 5:

  • http://proxy:8080 uses HTTP.
  • https://proxy:8080 uses SSL.
  • socks4://proxy:8080 uses SOCKS 4.
  • socks5://proxy:8080 uses SOCKS 5.
  • socks://proxy:8080 uses SOCKS 5, as schema "socks" is alias for schema "socks5".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither socks4 nor socks5 is a valid schema as supported by Firefox. For socks proxy there is usually no schema at all when specifying the host. Does Chrome support that? Also note the other comment above regarding the backward incompatible change.

Does it mean that Firefox cannot proxy SOCKS 5 via SOCKS 4 and vice versa?

@sadym-chromium
Copy link
Contributor Author

@whimboo WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants