Skip to content

Restyle figures and captions #4276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 6, 2025
Merged

Restyle figures and captions #4276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c2077e9
Restyle figure captions
patrickhlauke Mar 13, 2025
fb9d973
Optional: add light gray border around figure images themselves
patrickhlauke Mar 13, 2025
584b016
Inline "Figure", move border back to bottom
patrickhlauke Mar 21, 2025
766f683
Merge branch 'main' into patrickhlauke-figcaption-restyle
patrickhlauke Apr 4, 2025
b8b0fdd
Move border to left-hand side of figure
patrickhlauke Apr 6, 2025
d8b3c20
Merge branch 'patrickhlauke-figcaption-restyle' of https://github.com…
patrickhlauke Apr 6, 2025
d48dc33
Merge branch 'main' into patrickhlauke-figcaption-restyle
patrickhlauke Apr 25, 2025
da42b75
Merge branch 'main' into patrickhlauke-figcaption-restyle
mbgower May 6, 2025
b63a36d
Merge branch 'main' into patrickhlauke-figcaption-restyle
mbgower May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 11ty/CustomLiquid.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ export class CustomLiquid extends Liquid {
$("figcaption").each((i, el) => {
const $el = $(el);
if (!$el.find("p").length) $el.wrapInner("<p></p>");
$el.prepend(`Figure ${i + 1}`);
$el.find("p").first().prepend(`<span>Figure ${i + 1}.</span> `);
});

// Remove spurious copy-pasted content in 2.5.3 that doesn't belong there
Expand Down
22 changes: 21 additions & 1 deletion css/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,26 @@ margin-right:.8em;
margin-left: 2em;
}

/* overrides for restyled figures and captions */

figure {
margin: 2em 0;
padding-left: 1em;
border-left: 2px solid var(--cloudy);
}

figure img,
figure video,
figure svg {
border: 1px solid var(--line-grey);
}

figcaption {
font-weight: initial;
border-bottom: initial;
font-size: 0.9rem;
}

@media (max-width: 35em) {
.nav-container {
padding: 0;
Expand All @@ -438,7 +458,7 @@ margin-right:.8em;
display: inline-block;
width: calc(100% - 2em);
}
@supports (display:gred) {
@supports (display:grid) {
#site-header {
padding-left: 0;
}
Expand Down