Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update text-spacing.html #4125

Merged
merged 10 commits into from
Feb 18, 2025
Merged

Update text-spacing.html #4125

merged 10 commits into from
Feb 18, 2025

Conversation

mbgower
Copy link
Contributor

@mbgower mbgower commented Oct 30, 2024 •
edited
Loading

Minor revisions to the Understanding document, mainly already reviewed in #1457, but Incorporated into a clean PR

@mbgower
Update text-spacing.html
11191cf 
Incorporated changes from #1457 into a clean PR
@mbgower mbgower mentioned this pull request Oct 30, 2024
Closed
@netlify Netlify
Copy link

netlify bot commented Oct 30, 2024 •
edited
Loading

✅ Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit 60ac6a3
🔍 Latest deploy log https://app.netlify.com/sites/wcag2/deploys/67b4c05051854d0008874249
😎 Deploy Preview https://deploy-preview-4125--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bruce-usab
bruce-usab requested changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@bruce-usab bruce-usab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like Alistair's edit -- as it is simplifies an audit.

@bruce-usab
Copy link
Contributor

See preview diff for Understanding 4.1.12

@alastc
Copy link
Contributor

alastc commented Jan 10, 2025

Just needs a quick review from a couple of people.

@patrickhlauke patrickhlauke self-requested a review January 10, 2025 16:27
patrickhlauke
patrickhlauke requested changes Jan 17, 2025
View reviewed changes
Copy link
Member

@patrickhlauke patrickhlauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per @gundulaniemann comment, it's not necessarily "increase" but rather "change"

@patrickhlauke patrickhlauke self-assigned this Jan 17, 2025
kfranqueiro and others added 2 commits January 17, 2025 11:12
@kfranqueiro @patrickhlauke
an increase -> a change
442ddf6 
Co-authored-by: Patrick H. Lauke <[email protected]>
@kfranqueiro @patrickhlauke
increases -> changes
4d6fd72 
Co-authored-by: Patrick H. Lauke <[email protected]>
@bruce-usab
Copy link
Contributor

Reviewed and approved on call 1/17.

@mbgower mbgower merged commit 0802b69 into main Feb 18, 2025
1 check passed
@mbgower mbgower deleted the TextSpacingUnderstanding branch February 18, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alastc alastc alastc left review comments

@gundulaniemann gundulaniemann gundulaniemann left review comments

@patrickhlauke patrickhlauke patrickhlauke approved these changes

@scottaohara scottaohara scottaohara approved these changes

@bruce-usab bruce-usab bruce-usab approved these changes

Assignees

@patrickhlauke patrickhlauke

Labels
1.4.12 text spacing Substantive Understanding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mbgower @bruce-usab @alastc @patrickhlauke @scottaohara @gundulaniemann @kfranqueiro