Skip to content

Update F81 #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 25, 2025
Merged

Update F81 #1033

merged 13 commits into from
Aug 25, 2025

Conversation

JAWS-test2
Copy link
Contributor

Fixes #873

@JAWS-test JAWS-test mentioned this pull request Feb 4, 2020
Closed
@Myndex
Copy link
Member

Myndex commented Feb 26, 2020

Objection

The line "A minimum contrast ratio of 3:1 is considered sufficient." does not belong in this criterion and creates a conflict with the other SCs that define luminance.

Side note: the term is luminance not luminosity.

Also, the word "are" was incorrectly removed from the change in the first paragraph.

@JAWS-test
Copy link

JAWS-test commented Feb 26, 2020 •
edited
Loading

The line "A minimum contrast ratio of 3:1 is considered sufficient." does not belong in this criterion and creates a conflict with the other SCs that define luminance.

The exception regarding contrast was already in F81, without an exact specification of the contrast ratio. The text has been inserted to be compliant with https://www.w3.org/WAI/WCAG21/Techniques/general/G183 and with #873.

@JAWS-test JAWS-test mentioned this pull request Mar 9, 2020
Closed
yatil
yatil reviewed May 7, 2020
View reviewed changes
yatil
yatil reviewed May 7, 2020
View reviewed changes
Base automatically changed from master to main March 5, 2021 20:42
@kfranqueiro kfranqueiro removed the request for review from michael-n-cooper May 5, 2025 14:14
@netlify Netlify
Copy link

netlify bot commented Jun 5, 2025 •
edited
Loading

✅ Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit 464f15e
🔍 Latest deploy log https://app.netlify.com/projects/wcag2/deploys/68acc745d54d60000853b167
😎 Deploy Preview https://deploy-preview-1033--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

patrickhlauke
patrickhlauke reviewed Jun 27, 2025
View reviewed changes
patrickhlauke
patrickhlauke reviewed Jun 27, 2025
View reviewed changes
patrickhlauke
patrickhlauke reviewed Jun 27, 2025
View reviewed changes
@mbgower
Copy link
Contributor

mbgower commented Jun 27, 2025

@yatil do you have time to take a look at this?

mbgower and others added 2 commits June 27, 2025 08:27
@patrickhlauke patrickhlauke mentioned this pull request Jun 29, 2025
Merged
@patrickhlauke patrickhlauke self-assigned this Jun 29, 2025
@patrickhlauke
Copy link
Member

@yatil want to give this another look, or you happy with it?

@patrickhlauke patrickhlauke requested a review from yatil July 11, 2025 16:28
patrickhlauke
patrickhlauke approved these changes Jul 11, 2025
View reviewed changes
Copy link
Member

@patrickhlauke patrickhlauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few tweaks for better language/flow, but otherwise think this is good

@patrickhlauke
Copy link
Member

cross-reference to #4472 where the "colorblind" replacement happens for all other instances

mbgower added a commit that referenced this pull request Aug 5, 2025
@patrickhlauke @mbgower
Use "color vision deficiency" instead of "colorblindness" (#4472)
86a3732 
* includes reformatting/removal of empty lines on some of the files

follow-up to #1033 where I took the
opportunity to address F81

Co-authored-by: Mike Gower <[email protected]>
@bruce-usab
Copy link
Contributor

diff for F81: Failure of Success Criterion 1.4.1 due to identifying required or error fields using color differences only

@mbgower mbgower merged commit 293af1b into w3c:main Aug 25, 2025
5 checks passed
@kfranqueiro kfranqueiro mentioned this pull request Sep 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhlauke patrickhlauke patrickhlauke approved these changes

@scottaohara scottaohara scottaohara approved these changes

@bruce-usab bruce-usab bruce-usab approved these changes

@yatil yatil Awaiting requested review from yatil

+1 more reviewer

@hidde hidde hidde approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@patrickhlauke patrickhlauke

Labels
1.4.1 Use of Color Substantive Techniques
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explanation of exception in F81 insufficient
9 participants
@JAWS-test2 @Myndex @JAWS-test @mbgower @patrickhlauke @bruce-usab @yatil @hidde @scottaohara