Skip to content

Fix iframe promise rejection in unloading document cleanup #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
+4 −0
Open

Fix iframe promise rejection in unloading document cleanup #268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,6 +834,10 @@ <h2>
|document|, the user agent MUST run the following steps:
</p>
<ol class="algorithm">
<li>If |document|'s {{Document/[[orientationPendingPromise]]}} is not
`null`, [=reject and nullify the current lock promise=] of |document|
with an {{"AbortError"}}.
</li>
Comment on lines +837 to +840
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spec markup issues: (1) {{Document/[[orientationPendingPromise]]}} is not a valid Bikeshed/IDL reference for an internal slot; link the internal slot relative to the algorithm variable using [= |document| / [[orientationPendingPromise]] =]. (2) {{"AbortError"}} is not a valid IDL link; use 'AbortError' DOMException per standard phrasing. Suggested rewrite: If [= |document| / [[orientationPendingPromise]] =] is not null, [=reject and nullify the current lock promise=] of |document| with an 'AbortError' DOMException.

Copilot uses AI. Check for mistakes.

<li>If |document| is not a [=top-level browsing context=]'s
[=navigable/active document=], abort these steps.
</li>
Expand Down