-
Notifications
You must be signed in to change notification settings - Fork 29
Address privacy review feedback #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…th user attention
|
@bvandersloot-mozilla, would you mind having a look and let me know if you are satisfied? |
- Add fingerprinting warning to note about lock failures due to user preferences/platform limitations - Upgrade fullscreen requirement from SHOULD to MUST to prevent fingerprinting through differences in user agent behavior Addresses follow-up Privacy WG feedback.
Change from MAY to SHOULD for natural orientation obscuring protections, particularly in privacy-conscious contexts like private browsing modes. This addresses Privacy WG feedback about making natural orientation fingerprinting protection closer to standard behavior. Addresses: Privacy WG review feedback on natural orientation obscuring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Strengthens privacy protections and clarifies event delivery/locking by requiring orientation behavior only for documents that are fully active descendants of a top-level traversable with user attention, and by adding explicit anti-fingerprinting guidance.
- Replace visibility-only checks with a stronger “fully active descendant of a top-level traversable with user attention” gate for events and locking
- Elevate fullscreen pre-lock requirement from SHOULD to MUST to mitigate fingerprinting
- Add new privacy sections detailing event delivery restrictions and anti-fingerprinting mitigations
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 6 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes address the issues I filed! Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Closes #262
Closes #261
Closes #260
Closes #259
Closes #252
This pull request updates the screen orientation specification to strengthen privacy protections and clarify requirements for event delivery and locking behavior. The changes focus on restricting orientation events and locking to documents that are both visible and have user attention, and introduce new anti-fingerprinting mitigations.
Privacy and Fingerprinting Mitigations
index.html, index.htmlL727-R730)index.html, index.htmlL914-R956)Event Delivery and Locking Behavior
index.html, [1] [2] [3]ScreenOrientation.lock()in fullscreen contexts from "SHOULD" to "MUST", emphasizing that this restriction helps prevent fingerprinting via user agent behavior. (index.html, index.htmlL868-R876)Preview | Diff