Minor editorial changes suggested by @iherman. #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkellogg
added
the
spec:editorial
afs
approved these changes
Oct 22, 2024
domel
approved these changes
Oct 22, 2024
iherman
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
I agree with @TallTed in #73 (comment) on aligning the name of | with the official one. Approving provided that change.
That change should be in this PR already. |
iherman
approved these changes
Oct 23, 2024
spec/index.html
Outdated
| @@ -1648,9 +1648,9 @@ <h2>Selected Terminal Literal Strings</h2> | |||
| <dd>two concatenated circumflex accent characters, each having the code point <code class="codepoint">U+005E</code></dd> | |||
| <dt id="cp-curly-pipe"><code>{|</code></dt> | |||
| <dd><code title="left curly bracket">{</code> (left curly bracket, code point <code class="codepoint">U+007B</code>) followed by | |||
| <code title="verticle bar">|</code> (verticle bar, code point <code class="codepoint">U+007C</code>)</dd> | |||
| <code title="vertical bar">|</code> (vertical bar, code point <code class="codepoint">U+007C</code>)</dd> | |||
There was a problem hiding this comment.
Suggested change
| <code title="vertical bar">|</code> (vertical bar, code point <code class="codepoint">U+007C</code>)</dd> | |
| <code title="vertical line">|</code> (vertical line, code point <code class="codepoint">U+007C</code>)</dd> |
spec/index.html
Outdated
Comment on lines
1602
to
1603
| <td><code title="vertical bar">|</code></td> | ||
| <td>Vertical bar</td> |
There was a problem hiding this comment.
Suggested change
| <td><code title="vertical bar">|</code></td> | |
| <td>Vertical bar</td> | |
| <td><code title="vertical line">|</code></td> | |
| <td>Vertical line</td> |
spec/index.html
Outdated
| <dt id="cp-pipe-curly"><code>|}</code></dt> | ||
| <dd><code title="verticle bar">|</code> (verticle bar, code point <code class="codepoint">U+007C</code>) followed by | ||
| <dd><code title="vertical bar">|</code> (vertical bar, code point <code class="codepoint">U+007C</code>) followed by |
There was a problem hiding this comment.
Suggested change
| <dd><code title="vertical bar">|</code> (vertical bar, code point <code class="codepoint">U+007C</code>) followed by | |
| <dd><code title="vertical line">|</code> (vertical line, code point <code class="codepoint">U+007C</code>) followed by |
It wasn't... See my change comments. cc @TallTed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73.
Preview | Diff