-
Notifications
You must be signed in to change notification settings - Fork 10
add equation-label for w3c/mathml#525 #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
I would move this change to
open-properties.yml
for an experimentation phase. This is admittedly a minority position in the last WG meeting. -
equation-label
is a reasonable name. -
no-equation-label
reads ad-hoc to me. LaTeX uses\notag
to keep lines unmarked, so I can guess at the origin. Is there a strong motivation why this is needed beyond:silent
or just the default empty<mtd></mtd>
readout? Or even if a simple comment documenting that<mtd intent=":equation-label"></mtd>
will be assumed to be a scaffolding cell when left empty? Adding an extra entry seems a bit over-engineered.
Yes noted. I thought you'd say that and explicitly pinged you as a reviewer to make sure you saw this and had chance to add a dissenting comment. As we discussed there are benefits to having this in core.
In MathML3 (and earlier) So the proposal here is that mlabeledtr is replaced by mtr with the distinguished mtd having a Actually I think MathCat ignores it (as it doesn't announce columns for |
Note the current implementation only supports the extra cells being the first in each row, which means that you could actually just assert that any first cell without |
Merging as this is a prerequisite for the approved w3c/mathml/pull/529 |
As discussed in w3c/mathml#525 this adds
equation-label
(andno-equation-label
) properties to identify equation labels inmtable
.These properties have been tested with test implementation in LaTeX (for generation) and MathCAT (reading) and greatly improve the reading of aligned math displays.
Following discussion in the issue, and in WG zoom meetings, the text added by this PR is quite general, it does not constrain the label to be in the first column, or mandate any particular behaviour, it just standardises the property to be available as a way to mark those cells which are labels.