-
Notifications
You must be signed in to change notification settings - Fork 14
Clarify layout of large operators algorithm #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't check the details of the math, but that looks good overall. I wonder whether we could factor out some logic that is shared with the vertical stretching? Maybe that can simplify things...
Also, I believe this is actually changing current behavior, so we would need to check whether the WG is ok with that.
d2a3cff
to
0948a91
Compare
0948a91
to
9e704e9
Compare
9e704e9
to
0bfc043
Compare
We discussed this with Harry last week and probably we can merge it if the WG is happy with this change. However, Harry is still experimenting a patch on this change in Chromium and will write new WPT tests / update existing ones, so we may also wait a bit to be sure there is no unexpected side effect. |
@fred-wang / @icesfont can you update us on the status here as relates to this PR? |
The change is out in Chromium as part of this bugfix: https://issues.chromium.org/issues/40889877 |
I believe this can me merged if the Math WG is happy with that. Harry wrote mathml/presentation-markup/operators/symmetric-largeop.html to check it. |
Please see #250.
For now, if the largeop doesn't have the symmetric property, then the center of the stretchy glyph is not shifted towards the center of the target. I'm not sure how common of a case largeop without symmetric is; the operator dictionary has no such cases, and the issue linked only concerns symmetric + largeop. If this turns out to be a problem then perhaps the center should be shifted to the center of the original unstretched glyph.
This PR should be complemented by changes to MathML Full too -- c.f.:
https://www.w3.org/TR/MathML/chapter3.html#presm.table-mo
https://www.w3.org/TR/MathML/chapter3.html#presm.op.stretch
https://www.w3.org/TR/MathML/chapter3.html#id.3.2.5.8.2