Skip to content

Conversation

@lukewarlow
Copy link
Member

@lukewarlow lukewarlow commented Mar 22, 2025

Fixes #11841

@lukewarlow lukewarlow requested a review from nt1m March 22, 2025 09:54
@lukewarlow lukewarlow changed the title [css-forms-1] Remove ::track from layout rule [css-forms-1] Remove ::slider-track from layout rule Apr 30, 2025
@lukewarlow
Copy link
Member Author

cc @nt1m does this seem reasonable to merge? Or should I try and get a discussion in the group for which approach is best? Seems like a bug fix personally?

@nt1m
Copy link
Member

nt1m commented May 1, 2025

It kind of depends on which way to go, if you want the more traditional slider style with the track smaller than the thumb, then maybe it makes more sense to remove the border from the host element rather the track.

Either way we go I'm fine accepting it as a bug fix in the short term, but it would be good to discuss that bigger decision in the WG.

@lukewarlow lukewarlow force-pushed the fix-double-borders branch from b48a5a4 to ff783cb Compare June 18, 2025 20:57
@lukewarlow lukewarlow changed the title [css-forms-1] Remove ::slider-track from layout rule [css-forms-1] Fix double borders Jun 18, 2025
@lukewarlow
Copy link
Member Author

I've swapped to the other approach where the track has the border NOT the container. As you say for stuff like range where you might want the track to be smaller (even some switches are like this), it doesn't make sense for the border to be on the parent container.

Removes borders from slider container elements.
@lukewarlow lukewarlow force-pushed the fix-double-borders branch from ff783cb to 23086fe Compare June 18, 2025 21:00
@lukewarlow
Copy link
Member Author

Going to merge as a bug fix but like you say we should have a wider discussion on this.

@lukewarlow lukewarlow merged commit 702224f into w3c:main Jun 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[css-forms-1] Double border style for progres, meter and input[type=checkbox][switch]

2 participants