Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-values-5] Handle attr() cycles #11459

Merged
merged 1 commit into from
Jan 14, 2025
Merged

[css-values-5] Handle attr() cycles #11459

merged 1 commit into from
Jan 14, 2025

Conversation

andruud
Copy link
Member

@andruud andruud commented Jan 8, 2025

No description provided.

@andruud andruud requested a review from tabatkins January 8, 2025 15:53
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jan 14, 2025
Handle substitutions in attributes in attr() with algorithm described
in [0] when syntax is not null. Cycles handling is described in [1].

[0] https://drafts.csswg.org/css-values-5/#parse-with-a-syntax
[1] w3c/csswg-drafts#11459

Bug: 389496060
Change-Id: I6ee8f9d5977782ef7527bcfc54754fe2e4f9a199
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jan 14, 2025
Handle substitutions in attributes in attr() with algorithm described
in [0] when syntax is not null. Cycles handling is described in [1].

[0] https://drafts.csswg.org/css-values-5/#parse-with-a-syntax
[1] w3c/csswg-drafts#11459

Bug: 389496060
Change-Id: I6ee8f9d5977782ef7527bcfc54754fe2e4f9a199
aarongable pushed a commit to chromium/chromium that referenced this pull request Jan 14, 2025
Handle substitutions in attributes in attr() with algorithm described
in [0] when syntax is not null. Cycles handling is described in [1].

[0] https://drafts.csswg.org/css-values-5/#parse-with-a-syntax
[1] w3c/csswg-drafts#11459

Bug: 389496060
Change-Id: I6ee8f9d5977782ef7527bcfc54754fe2e4f9a199
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6157456
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Commit-Queue: Munira Tursunova <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1406027}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jan 14, 2025
Handle substitutions in attributes in attr() with algorithm described
in [0] when syntax is not null. Cycles handling is described in [1].

[0] https://drafts.csswg.org/css-values-5/#parse-with-a-syntax
[1] w3c/csswg-drafts#11459

Bug: 389496060
Change-Id: I6ee8f9d5977782ef7527bcfc54754fe2e4f9a199
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6157456
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Commit-Queue: Munira Tursunova <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1406027}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jan 14, 2025
Handle substitutions in attributes in attr() with algorithm described
in [0] when syntax is not null. Cycles handling is described in [1].

[0] https://drafts.csswg.org/css-values-5/#parse-with-a-syntax
[1] w3c/csswg-drafts#11459

Bug: 389496060
Change-Id: I6ee8f9d5977782ef7527bcfc54754fe2e4f9a199
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6157456
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Commit-Queue: Munira Tursunova <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1406027}
@tabatkins tabatkins merged commit 14ae4f6 into w3c:main Jan 14, 2025
1 check passed
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jan 16, 2025
…in attr(), a=testonly

Automatic update from web-platform-tests
Handle substitutions in attribute value in attr()

Handle substitutions in attributes in attr() with algorithm described
in [0] when syntax is not null. Cycles handling is described in [1].

[0] https://drafts.csswg.org/css-values-5/#parse-with-a-syntax
[1] w3c/csswg-drafts#11459

Bug: 389496060
Change-Id: I6ee8f9d5977782ef7527bcfc54754fe2e4f9a199
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6157456
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Commit-Queue: Munira Tursunova <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1406027}

--

wpt-commits: 6df16e4473285e94a5aad1e4958f0fbab3b7b860
wpt-pr: 50067
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this pull request Jan 17, 2025
…in attr(), a=testonly

Automatic update from web-platform-tests
Handle substitutions in attribute value in attr()

Handle substitutions in attributes in attr() with algorithm described
in [0] when syntax is not null. Cycles handling is described in [1].

[0] https://drafts.csswg.org/css-values-5/#parse-with-a-syntax
[1] w3c/csswg-drafts#11459

Bug: 389496060
Change-Id: I6ee8f9d5977782ef7527bcfc54754fe2e4f9a199
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6157456
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Commit-Queue: Munira Tursunova <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1406027}

--

wpt-commits: 6df16e4473285e94a5aad1e4958f0fbab3b7b860
wpt-pr: 50067
aarongable pushed a commit to chromium/chromium that referenced this pull request Feb 13, 2025
Handle substitutions in attributes in attr() with algorithm described
in [0] when syntax is not null. Cycles handling is described in [1].

[0] https://drafts.csswg.org/css-values-5/#parse-with-a-syntax
[1] w3c/csswg-drafts#11459

(cherry picked from commit e1c7874)

Bug: 389496060
Fixed: 389894013
Change-Id: I6ee8f9d5977782ef7527bcfc54754fe2e4f9a199
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6157456
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Commit-Queue: Munira Tursunova <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1406027}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6176920
Cr-Commit-Position: refs/branch-heads/6943@{#264}
Cr-Branched-From: 72dd0b3-refs/heads/main@{#1402768}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants