-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-values-5] Handle attr() cycles #11459
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 14, 2025
Handle substitutions in attributes in attr() with algorithm described in [0] when syntax is not null. Cycles handling is described in [1]. [0] https://drafts.csswg.org/css-values-5/#parse-with-a-syntax [1] w3c/csswg-drafts#11459 Bug: 389496060 Change-Id: I6ee8f9d5977782ef7527bcfc54754fe2e4f9a199
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 14, 2025
Handle substitutions in attributes in attr() with algorithm described in [0] when syntax is not null. Cycles handling is described in [1]. [0] https://drafts.csswg.org/css-values-5/#parse-with-a-syntax [1] w3c/csswg-drafts#11459 Bug: 389496060 Change-Id: I6ee8f9d5977782ef7527bcfc54754fe2e4f9a199
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jan 14, 2025
Handle substitutions in attributes in attr() with algorithm described in [0] when syntax is not null. Cycles handling is described in [1]. [0] https://drafts.csswg.org/css-values-5/#parse-with-a-syntax [1] w3c/csswg-drafts#11459 Bug: 389496060 Change-Id: I6ee8f9d5977782ef7527bcfc54754fe2e4f9a199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6157456 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Munira Tursunova <[email protected]> Cr-Commit-Position: refs/heads/main@{#1406027}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 14, 2025
Handle substitutions in attributes in attr() with algorithm described in [0] when syntax is not null. Cycles handling is described in [1]. [0] https://drafts.csswg.org/css-values-5/#parse-with-a-syntax [1] w3c/csswg-drafts#11459 Bug: 389496060 Change-Id: I6ee8f9d5977782ef7527bcfc54754fe2e4f9a199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6157456 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Munira Tursunova <[email protected]> Cr-Commit-Position: refs/heads/main@{#1406027}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 14, 2025
Handle substitutions in attributes in attr() with algorithm described in [0] when syntax is not null. Cycles handling is described in [1]. [0] https://drafts.csswg.org/css-values-5/#parse-with-a-syntax [1] w3c/csswg-drafts#11459 Bug: 389496060 Change-Id: I6ee8f9d5977782ef7527bcfc54754fe2e4f9a199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6157456 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Munira Tursunova <[email protected]> Cr-Commit-Position: refs/heads/main@{#1406027}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jan 16, 2025
…in attr(), a=testonly Automatic update from web-platform-tests Handle substitutions in attribute value in attr() Handle substitutions in attributes in attr() with algorithm described in [0] when syntax is not null. Cycles handling is described in [1]. [0] https://drafts.csswg.org/css-values-5/#parse-with-a-syntax [1] w3c/csswg-drafts#11459 Bug: 389496060 Change-Id: I6ee8f9d5977782ef7527bcfc54754fe2e4f9a199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6157456 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Munira Tursunova <[email protected]> Cr-Commit-Position: refs/heads/main@{#1406027} -- wpt-commits: 6df16e4473285e94a5aad1e4958f0fbab3b7b860 wpt-pr: 50067
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Jan 17, 2025
…in attr(), a=testonly Automatic update from web-platform-tests Handle substitutions in attribute value in attr() Handle substitutions in attributes in attr() with algorithm described in [0] when syntax is not null. Cycles handling is described in [1]. [0] https://drafts.csswg.org/css-values-5/#parse-with-a-syntax [1] w3c/csswg-drafts#11459 Bug: 389496060 Change-Id: I6ee8f9d5977782ef7527bcfc54754fe2e4f9a199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6157456 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Munira Tursunova <[email protected]> Cr-Commit-Position: refs/heads/main@{#1406027} -- wpt-commits: 6df16e4473285e94a5aad1e4958f0fbab3b7b860 wpt-pr: 50067
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Feb 13, 2025
Handle substitutions in attributes in attr() with algorithm described in [0] when syntax is not null. Cycles handling is described in [1]. [0] https://drafts.csswg.org/css-values-5/#parse-with-a-syntax [1] w3c/csswg-drafts#11459 (cherry picked from commit e1c7874) Bug: 389496060 Fixed: 389894013 Change-Id: I6ee8f9d5977782ef7527bcfc54754fe2e4f9a199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6157456 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Munira Tursunova <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1406027} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6176920 Cr-Commit-Position: refs/branch-heads/6943@{#264} Cr-Branched-From: 72dd0b3-refs/heads/main@{#1402768}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.