Fix inconsistent clamp_basetype handling in make_setter function #4642
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an inconsistency in the
make_setter
function invyper/codegen/core.py
. The function was handlingclamp_basetype
differently for primitive word types compared to other data types (like bytestrings and dynamic arrays).For other data types, the function properly:
cache_when_complex
IRnode.from_list()
callHowever, for primitive word types, it was directly assigning the result of
clamp_basetype(right)
back toright
, which could lead to potential issues with complex values and IR node construction.Changes
clamp_basetype
handling for primitive word types to use the same pattern as other data types