feat[tool]: add venom artifacts into solc_json output
#4637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iled result when calling compile_json()
Comment on lines
57
to
60
| translate_map.remove("bb") | ||
| translate_map.remove("bb_runtime") | ||
| translate_map.remove("cfg") | ||
| translate_map.remove("cfg_runtime") |
There was a problem hiding this comment.
style, bit more compact:
Suggested change
| translate_map.remove("bb") | |
| translate_map.remove("bb_runtime") | |
| translate_map.remove("cfg") | |
| translate_map.remove("cfg_runtime") | |
| venom_outputs = ("bb", "bb_runtime", "cfg", "cfg_runtime") | |
| for s in venom_outputs: | |
| translate_map.remove(s) |
vyper/cli/vyper_json.py
Outdated
| @@ -245,6 +249,10 @@ def get_output_formats(input_dict: dict) -> dict[PurePath, list[str]]: | |||
| raise JSONError(f"Invalid outputSelection - {e}") | |||
|
|
|||
| outputs = sorted(list(outputs)) | |||
| if not input_dict["settings"].get("venom") and not input_dict["settings"].get("experimentalCodegen"): | |||
| for key in ["bb", "bb_runtime", "cfg", "cfg_runtime"]: | |||
There was a problem hiding this comment.
maybe extract this list to a top level variable
vyper/cli/vyper_json.py
Outdated
| @@ -401,6 +409,18 @@ def format_to_output_dict(compiler_data: dict) -> dict: | |||
| if "source_map_runtime" in data: | |||
| evm["sourceMap"] = data["source_map_runtime"] | |||
|
|
|||
| venom_keys = ("bb", "bb_runtime", "cfg", "cfg_runtime",) | |||
There was a problem hiding this comment.
ditto -- venom_keys could be top level variable
charles-cooper
changed the title
solc_json output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I added the venom optimizer keys
['bb', 'bb_runtime', 'cfg', 'cfg_runtime']into the compiled output when callingcompile_json()How I did it
Adapted the translate map and guarded it with the
venomflagHow to verify it
Added tests inside
test_compile_json.pyCommit message
feat: add venom optimizer keys ['bb', 'bb_runtime', 'cfg', 'cfg_runtime'] into the compiled output when calling compile_json()Description for the changelog
['bb', 'bb_runtime', 'cfg', 'cfg_runtime']Cute Animal Picture