Skip to content

fix[venom]: fix inliner return items #4614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

charles-cooper
Copy link
Member

this fixes the function inliner returning items. currently in vyper, functions do not return stack items, so there was an assumption that ret had no arguments besides the return pc. this commit adds the store instructions so that the return items are set properly.

it also fixes a bug in InstUpdater, which is that invoke can have no outputs.

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

this fixes the function inliner returning items. currently in vyper,
functions do not return stack items, so there was an assumption that
`ret` had no arguments besides the return pc. this commit adds the store
instructions so that the return items are set properly.

it also fixes a bug in InstUpdater, which is that invoke can have no
outputs.
@charles-cooper charles-cooper marked this pull request as ready for review April 27, 2025 14:19
@charles-cooper charles-cooper requested a review from harkal April 27, 2025 14:20
Copy link

codecov bot commented Apr 27, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.79%. Comparing base (d8a143d) to head (8c77066).

Files with missing lines Patch % Lines
vyper/venom/basicblock.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4614      +/-   ##
==========================================
- Coverage   92.79%   92.79%   -0.01%     
==========================================
  Files         131      131              
  Lines       18973    18977       +4     
  Branches     3288     3289       +1     
==========================================
+ Hits        17606    17609       +3     
  Misses        934      934              
- Partials      433      434       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant