fix[venom]: fix inliner return items #4614
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fixes the function inliner returning items. currently in vyper, functions do not return stack items, so there was an assumption that `ret` had no arguments besides the return pc. this commit adds the store instructions so that the return items are set properly. it also fixes a bug in InstUpdater, which is that invoke can have no outputs.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4614 +/- ##
==========================================
- Coverage 92.79% 92.79% -0.01%
==========================================
Files 131 131
Lines 18973 18977 +4
Branches 3288 3289 +1
==========================================
+ Hits 17606 17609 +3
Misses 934 934
- Partials 433 434 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes the function inliner returning items. currently in vyper, functions do not return stack items, so there was an assumption that
rethad no arguments besides the return pc. this commit adds the store instructions so that the return items are set properly.it also fixes a bug in InstUpdater, which is that invoke can have no outputs.
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture