-
-
Notifications
You must be signed in to change notification settings - Fork 850
perf[venom]: improve CSE elimination speed #4607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf[venom]: improve CSE elimination speed #4607
Conversation
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4607 +/- ##
==========================================
+ Coverage 92.79% 92.81% +0.01%
==========================================
Files 131 131
Lines 18845 18858 +13
Branches 3274 3273 -1
==========================================
+ Hits 17488 17503 +15
+ Misses 928 927 -1
+ Partials 429 428 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
for item in lattices[1:]: | ||
tmp = res | ||
res = _AvailableExpressions() | ||
mt = res.exprs.mutate() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you not use with
as in the add method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question, i think i just didn't like the level of nesting 😂
i think both versions do more or less the same thing though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved without review. with @charles-cooper we analyzed the risks of introducing the new dependency a few weeks ago and reached consensus it should be safe
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture