Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container Registry #134

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jasites
Copy link
Contributor

@jasites jasites commented Mar 23, 2025

Description

Adds initial support for Vultr Container Registry

  • Registry plan info module (plan_container_registry_info)
  • Registry CRUD module (container_registry)
  • Registry info module (container_registry_info)
  • Registry repository RUD module (container_registry_repository)
    • Create is done via container push, hence the commented out section of the integration test
      • Advice/suggestions there are greatly appreciated
  • Registry repository info module (container_registry_repository_info)
  • Registry region info module (container_registry_region_info)

The work for managing repo users was started, but while that was being done, extensive work was done to expand the options available for managing users via the API. As this was getting rather cumbersome as it is, I wanted to get this in before starting on the user management portion.

Related Issues

Resolves #107

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

jasites added 2 commits March 23, 2025 12:38
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 59.24%. Comparing base (e193c3e) to head (57ad1c6).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
plugins/module_utils/vultr_v2.py 0.00% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #134       +/-   ##
===========================================
- Coverage   89.70%   59.24%   -30.47%     
===========================================
  Files          33        3       -30     
  Lines        1010      449      -561     
  Branches      171       73       -98     
===========================================
- Hits          906      266      -640     
- Misses         45      182      +137     
+ Partials       59        1       -58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jasites jasites requested a review from resmo March 31, 2025 13:11
@jasites
Copy link
Contributor Author

jasites commented Mar 31, 2025

@resmo I'm sure there are a few changes that are needed here, but I would need fresh eyes to spot them.

Also, the version used in the changes was made early in the process of building this out - would 1.14.0 be a more proper value to use?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] - Container Registry support
2 participants