Skip to content

fix: [tests] Comment on an existing vulnerability, not a hardcoded CVE #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cedricbonhomme merged 1 commit into from
Jul 22, 2026
Merged

fix: [tests] Comment on an existing vulnerability, not a hardcoded CVE #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 23 additions & 6 deletions tests/test_web.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,15 @@ def test_comments_local(self) -> None:
return None
# Makes sure the userkey is set to the right one
self.client.set_apikey(self.admin_token)

# Comment creation requires the target vulnerability to exist in the
# instance, so comment on one that is actually imported (the CI sample
# instance loads pysec) rather than a hardcoded id.
last = self.client.get_last(source="pysec", number=1)
if not last:
return None
vuln_id = last[-1]["id"]

comments = self.client.get_comments()
self.assertTrue("metadata" in comments)
self.assertTrue("data" in comments)
Expand All @@ -142,7 +151,7 @@ def test_comments_local(self) -> None:
"title": "Comment",
"description": "Comment",
"description_format": "markdown",
"vulnerability": "CVE-2024-20401",
"vulnerability": vuln_id,
"related_vulnerabilities": ["ghsa-4rcj-fmjg-q9fv"],
}
comments = self.client.create_comment(comment=comment)
Expand All @@ -161,24 +170,24 @@ def test_comments_local(self) -> None:
comments["data"][0]["uuid"], "a309d024-2714-4a81-a425-60f83f6d5740"
)

comments = self.client.get_comments(vuln_id="CVE-2024-20401")
comments = self.client.get_comments(vuln_id=vuln_id)
self.assertTrue(len(comments["data"]) >= 1)
for comment in comments["data"]:
self.assertEqual(comment["vulnerability"], "CVE-2024-20401")
self.assertEqual(comment["vulnerability"], vuln_id)

# comments = self.client.get_comments(author='admin')
# self.assertTrue(len(comments['data']) >= 1)
# for comment in comments['data']:
# self.assertEqual(comment['author']['login'], 'admin') # type: ignore[call-overload]

comments = self.client.get_comments(
uuid="a309d024-2714-4a81-a425-60f83f6d5740", vuln_id="CVE-2024-20401"
uuid="a309d024-2714-4a81-a425-60f83f6d5740", vuln_id=vuln_id
)
self.assertTrue(len(comments["data"]) == 1)
self.assertEqual(
comments["data"][0]["uuid"], "a309d024-2714-4a81-a425-60f83f6d5740"
)
self.assertEqual(comments["data"][0]["vulnerability"], "CVE-2024-20401")
self.assertEqual(comments["data"][0]["vulnerability"], vuln_id)
# self.assertEqual(comments['data'][0]['author']['login'], 'admin')

status_code = self.client.delete_comment("a309d024-2714-4a81-a425-60f83f6d5740")
Expand Down Expand Up @@ -339,8 +348,16 @@ def test_create_user_comment(self) -> None:
self.assertTrue('login' in user, user)
# self.assertTrue('apikey' in user, user)
# self.client.set_apikey(user['apikey'])

# Comment creation requires the target vulnerability to exist, so use
# one actually imported by the instance (pysec in CI).
last = self.client.get_last(source='pysec', number=1)
if not last:
return None
vuln_id = last[-1]['id']

comment = {'title': 'test', 'description': 'test',
'vulnerability': 'CVE-2024-20401',
'vulnerability': vuln_id,
'related_vulnerabilities': ['CVE-2024-20402']}
created_comment = self.client.create_comment(comment=comment)
print(created_comment)
Expand Down