refactor: better typescript integration #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `no-unused-vars` rule was causing false positives for variables in type declarations.
fix: explicitly define exports refactor: reorganize type declarations and exports build: add tsconfig.json for TypeScript project configuration build: add missing type declaration files to package.json build: add tsconfig.json to package.json chore: remove tsconfig for distribution
|
What is your process for testing / checking this in a project? |
|
For vuetify/one I used installation from github |
johnleider
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we add additional types for typescript imports, disable
no-unused-varsrule to prevent false positive errors inside type definitions. And also some chores and stylistic clarifications