Skip to content

Update integrations eslint config to use ESLint v9 #7265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

sethidden
Copy link
Contributor

@sethidden sethidden commented Oct 2, 2024

eslint-plugin-import now supports v9 but I have to bump the pkg version here
import-js/eslint-plugin-import#2948 (comment)

eslint-config-airbnb-base is tracked here:
airbnb/javascript#2961

@sethidden sethidden requested a review from a team as a code owner October 2, 2024 07:29
Copy link

changeset-bot bot commented Oct 2, 2024

🦋 Changeset detected

Latest commit: 4bfe675

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vue-storefront/eslint-config-integrations Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sethidden sethidden force-pushed the update-dependencies branch 3 times, most recently from 97f3484 to 3ee5502 Compare October 2, 2024 07:41
eslint-plugin-import doesn't support v9 yet, but there'll posibly be a
release this week
import-js/eslint-plugin-import#2948 (comment)
@sethidden sethidden force-pushed the update-dependencies branch from 3ee5502 to 26a1140 Compare October 2, 2024 07:43
@sethidden sethidden marked this pull request as draft October 2, 2024 13:18
Copy link

@sethidden
Copy link
Contributor Author

sethidden commented Nov 19, 2024

@WojtekTheWebDev could integrations just switch to using unified's eslint config? https://github.com/vuestorefront/vue-storefront/tree/main/engineering-toolkit/eslint-config

I don't see much point upgrading this config (the eslint-config-airbnb package will probably never be upgraded to eslint v9) and ESLint v8 is already out of support

@sethidden
Copy link
Contributor Author

Wojtek says now Lukasz S and Bartek are bosses now

@sethidden
Copy link
Contributor Author

Bartek said it's ok to use unified-storefronts eslint config instead of maintaing this one

see https://github.com/vuestorefront/enterprise/pull/432

@sethidden sethidden closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant